Ticket #1212 (closed: fixed)
Monte Carlo Absorption correction
Reported by: | Nick Draper | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | critical | Milestone: | Iteration 26 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description
Change History
comment:2 Changed 10 years ago by Nick Draper
- Owner changed from Russell Taylor to Martyn Gigg
- Status changed from accepted to assigned
- Milestone changed from Iteration 24 to Iteration 25
Moved to Martyn Gigg, Russell will still be onvolved, but in a more distant role
comment:5 Changed 10 years ago by Martyn Gigg
- Status changed from assigned to accepted
- Component set to Mantid
comment:8 Changed 10 years ago by Janik Zikovsky
(Sorry I replied in the wrong ticket)
Hi Martyn,
Your last change broke some of the behaviour of the Instrument 3D view for RectangularDetectors. To reproduce:
- LoadEmptyInstrument with the SNAP_Definition.xml file.
- Show Instrument menu. You notice that only one sphere is shown (the sample I think) because the bounding box is ~ null in size.
- Click on any rectangular detector E1 E2 etc. in the view and nothing is shown. This all used to work and the RectangularDetector bounding boxes returned correctly.
comment:10 Changed 10 years ago by Martyn Gigg
comment:11 Changed 10 years ago by Martyn Gigg
comment:12 Changed 10 years ago by Martyn Gigg
comment:13 Changed 10 years ago by Martyn Gigg
comment:14 Changed 10 years ago by Martyn Gigg
comment:15 Changed 10 years ago by Martyn Gigg
comment:16 Changed 10 years ago by Martyn Gigg
comment:17 Changed 10 years ago by Martyn Gigg
comment:19 Changed 10 years ago by Martyn Gigg
comment:20 Changed 10 years ago by Martyn Gigg
comment:21 Changed 10 years ago by Martyn Gigg
comment:22 Changed 10 years ago by Martyn Gigg
comment:23 Changed 10 years ago by Martyn Gigg
comment:24 Changed 10 years ago by Martyn Gigg
comment:25 Changed 10 years ago by Martyn Gigg
comment:26 Changed 10 years ago by Martyn Gigg
comment:27 Changed 10 years ago by Martyn Gigg
comment:28 Changed 10 years ago by Martyn Gigg
comment:29 Changed 10 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:30 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:31 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 26
Sorry I didn't mean to move these ones reverting back to It 26
comment:32 Changed 10 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:33 Changed 10 years ago by Anders Markvardsen
- Status changed from verifying to verify
- Tester Anders Markvardsen deleted
comment:34 Changed 10 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:35 Changed 10 years ago by Russell Taylor
comment:36 Changed 10 years ago by Russell Taylor
- Status changed from verifying to closed
Looks good up to this point. Testing has included the following:
- Various sample shapes - cylinder, flat plate. Agrees with 'old' absorption correction method.
- Adding a simple sample environment.
- Including spectra with no detector.
- Changing the seed.
- Checked for memory leaks - none found.
comment:37 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2059
Note: See
TracTickets for help on using
tickets.