Ticket #1212 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Monte Carlo Absorption correction

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description


Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Nick Draper

  • Owner changed from Russell Taylor to Martyn Gigg
  • Status changed from accepted to assigned
  • Milestone changed from Iteration 24 to Iteration 25

Moved to Martyn Gigg, Russell will still be onvolved, but in a more distant role

comment:3 Changed 10 years ago by Martyn Gigg

(In [6691]) Added a BoundingBox class and implemented caching at the CompAssembly level. Note that there are still several functions using the old getBoundingBox methods but this covers a lot of the needed code for the MC correction. Re #1212

comment:4 Changed 10 years ago by Martyn Gigg

(In [6695]) Remove class name from header declaration to fix build. Re #1212

comment:5 Changed 10 years ago by Martyn Gigg

  • Status changed from assigned to accepted
  • Component set to Mantid

comment:6 Changed 10 years ago by Martyn Gigg

(In [6860]) More updates to geometry for ray tracing/Monte Carlo framework, Re #1212. Removed unused material fields from Object class, Re #1735

comment:7 Changed 10 years ago by Martyn Gigg

(In [6861]) Missed a reference to a function in MantidPlot code. Re #1212

comment:8 Changed 10 years ago by Janik Zikovsky

(Sorry I replied in the wrong ticket)

Hi Martyn,

Your last change broke some of the behaviour of the Instrument 3D view for RectangularDetectors. To reproduce:

  1. LoadEmptyInstrument with the SNAP_Definition.xml file.
  2. Show Instrument menu. You notice that only one sphere is shown (the sample I think) because the bounding box is ~ null in size.
  3. Click on any rectangular detector E1 E2 etc. in the view and nothing is shown. This all used to work and the RectangularDetector bounding boxes returned correctly.

comment:9 Changed 10 years ago by Martyn Gigg

(In [6871]) Move the Instrument and Instrument interface classes down to Geometry. The new raytracing framework needs instrument access and it should all be in geometry. Also, given that everything else was defined in geometry it seems to make more sense to have it all in one place. Re #1212

comment:10 Changed 10 years ago by Martyn Gigg

(In [6872]) Fix tests which contained references to API::Instrument. Not sure why they ran when I tried them... Re #1212

comment:11 Changed 10 years ago by Martyn Gigg

(In [6873]) Missed a few forward declarations and apparently "Find All" doesn't mean that. Re #1212

comment:12 Changed 10 years ago by Martyn Gigg

(In [6875]) Revert some changes to Rectangular detector that have broken Janik's functionality until I get a better understanding of why the GUI gives different answers for bounding boxes than the unit tests. Re #1212

comment:13 Changed 10 years ago by Martyn Gigg

(In [6901]) Add a getChild access method as well as the operator[] to the component assembly interface so that it's easier to use with pointers. Re #1212

comment:14 Changed 10 years ago by Martyn Gigg

(In [6905]) Reinstate original changes to RectangularDetector and update LoadInstrument to take the shape from the correct tag in the instrument definition. Re #1212

comment:15 Changed 10 years ago by Martyn Gigg

(In [6907]) Missed the MantidPlot actor class on last check in. Re #1212

comment:16 Changed 10 years ago by Martyn Gigg

(In [7000]) Add InstrumentRayTracer class. Also updated names of Geometry::Track related classes and members so that they are easier to read. A fair few changes but worth it for clarity. Re #1212

comment:17 Changed 10 years ago by Martyn Gigg

(In [7001]) Fix tests. Missed a modifier on a helper function to allow passing temporary values. Re #1212

comment:18 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 25 to Iteration 26

comment:19 Changed 10 years ago by Martyn Gigg

(In [7361]) Altered slightly how the ray tracing framework and tracks in general accumulate their intersections results to improve the performance of tracing. Also altered Object bounding boxes so that they are no longer created with the new operator. Re #1212

comment:20 Changed 10 years ago by Martyn Gigg

(In [7675]) Added a random number generator interface along with an implementation of the Mersenne Twister 19937 algorithm from boost. Re #1212

comment:21 Changed 10 years ago by Martyn Gigg

(In [7680]) Fix a compiler bug with the older version of boost on rhel5. Re #1212

comment:22 Changed 10 years ago by Martyn Gigg

(In [7821]) Adding the SampleEnvironment class plus changes around Geometry for the Monte Carlo work. Some changes in Geometry just clear warnings surrounding unitialized objects in copy constructors for class with virtual base classes. Other changes revolve around materials. Re #1212

comment:23 Changed 10 years ago by Martyn Gigg

(In [7822]) Add missing export modifier for Windows. Re #1212

comment:24 Changed 10 years ago by Martyn Gigg

(In [7823]) Fix method call after name change. Re #1212

comment:25 Changed 10 years ago by Martyn Gigg

(In [7896]) Update the material class. Re #1212

comment:26 Changed 10 years ago by Martyn Gigg

(In [7901]) Missed a file. Re #1212

comment:27 Changed 10 years ago by Martyn Gigg

(In [7936]) MC Absorption correction. Re #1212

comment:28 Changed 10 years ago by Martyn Gigg

(In [7938]) Fix for windows build. Re #1212

comment:29 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:30 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:31 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 26

Sorry I didn't mean to move these ones reverting back to It 26

comment:32 Changed 10 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:33 Changed 10 years ago by Anders Markvardsen

  • Status changed from verifying to verify
  • Tester Anders Markvardsen deleted

comment:34 Changed 10 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:35 Changed 10 years ago by Russell Taylor

(In [8209]) Add new InstrumentValidator to input workspace to prevent seg fault if no instrument defined. Re #1212. Other diffs are simply replacing tabs with spaces.

comment:36 Changed 10 years ago by Russell Taylor

  • Status changed from verifying to closed

Looks good up to this point. Testing has included the following:

  • Various sample shapes - cylinder, flat plate. Agrees with 'old' absorption correction method.
  • Adding a simple sample environment.
  • Including spectra with no detector.
  • Changing the seed.
  • Checked for memory leaks - none found.

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2059

Note: See TracTickets for help on using tickets.