Ticket #1292 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Pass by value instead of reference in UnaryOperation::performUnaryOperation method

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 23
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [4766]) Change UnaryOperation::performUnaryOperation method to pass input numbers by value instead of by reference. This not only avoids possible errors when the input & output workspaces are the same, but is also significantly faster on Windows (and no slower on Linux). Re #1292.

comment:3 Changed 10 years ago by Russell Taylor

(In [4768]) Fix test. Re #1292.

comment:4 Changed 10 years ago by Russell Taylor

(In [4778]) Make thread-safe (will fix intermittent test failure). Re #1292.

comment:5 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:6 Changed 10 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2139

Note: See TracTickets for help on using tickets.