Ticket #1319 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Workspace Groups:Not sending error notification when it fails

Reported by: Sofia Antony Owned by: Nick Draper
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Processgroups is not sending error notification when the algorithm fails.

Change History

comment:1 Changed 10 years ago by Sofia Antony

(In [4863]) re #1319 - added error notification to Processgroups

comment:2 Changed 10 years ago by Sofia Antony

(In [4867]) re #1319 - fix for error return in Processgroups

comment:3 Changed 10 years ago by Nick Draper

  • Owner set to Sofia Antony
  • Status changed from new to assigned

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:5 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:7 Changed 9 years ago by Nick Draper

  • Owner Sofia Antony deleted
  • Status changed from assigned to new

Taken from Sofia Antony's list after she left

comment:8 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:9 Changed 9 years ago by Nick Draper

  • Status changed from new to accepted
  • Owner set to Nick Draper
  • Component set to Mantid

This looks like it was fixed some time ago. Moving to testing.

To test Run an algorithm over a group that will fail on one member of the group.

I suggest you create a custom group with an odd collection of workspaces for this.

comment:10 Changed 9 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:12 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to verify
  • Tester Janik Zikovsky deleted

comment:13 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:14 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

The core problem has been fixed, i.e. the notification is propagated up but when the algorithm fails you end up with a blank WorkspaceGroup in the ADS.

I think this is due to line 1113 in Algorithm.cpp but I'm reluctant to alter such a core class this late in testing. Ticket #3760 has been created to look at this.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2166

Note: See TracTickets for help on using tickets.