Ticket #3760 (assigned)

Opened 9 years ago

Last modified 5 years ago

Empty WorkspaceGroup created when an algorithm that is operating on two groups fails

Reported by: Martyn Gigg Owned by: Roman Tolchenov
Priority: major Milestone: Backlog
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Martyn Gigg) (diff)

This was revealed when testing #1319.

The easiest way to reproduce this is:

  • Load a file twice into separate workspaces
  • Click Group
  • Run the DiffractionFocussing algorithm which should fail as the workspaces are not in the correct unit.
  • When the algorithm fails there will be an empty group with the name of the OutputWorkspace in the ADS

I believe the issue is somewhere around line 1113 of Algorithm.cpp but the code is difficult to understand and would benefit from a refactoring. This is noted by #996

Problem (2) in #3695 also raise a separate but related issue with Algorithm::processGroups and that should be addressed with this ticket also:

The issue is that processGroups sets ALL input workspaces its child algorithm so for things like NormaliseToMonitor example herethis causes it to fail as you end up setting properties that weren't set on the original algorithm. I have added this as part of #3760 as it is related.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to assigned

comment:2 Changed 9 years ago by Martyn Gigg

  • Description modified (diff)

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:9 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Roman Tolchenov

for consideration with WS group work

comment:10 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:11 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:12 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:13 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4607

Note: See TracTickets for help on using tickets.