WorkspaceGroups are failing in some algorithms

[Martyn Gigg]

From Tim Charlton,

FileName="D:/data/cycle_11_2/POLREF00004711.raw"
Load(Filename=FileName,OutputWorkspace="_Raw")
ConvertUnits(InputWorkspace="_Raw",OutputWorkspace="_Raw",Target="Wavelength")
NormaliseByCurrent(InputWorkspace="_Raw",OutputWorkspace="_D")

Io=CropWorkspace('_D','Io',StartWorkspaceIndex=2,EndWorkspaceIndex=2)
I=CropWorkspace('_D','I',StartWorkspaceIndex=4)

I=mtd['I'];Io=mtd['Io']
R=I/Io


Fails with error:


Python.ArgumentError on line 10: "Python argument types in
    MantidPythonAPI._binary_op(WorkspaceGroup, WorkspaceGroup, str, str, bool, bool)
did not match C++ signature:
    _binary_op(class boost::shared_ptr<class Mantid::API::MatrixWorkspace>, double, class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >, class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >, bool, bool)
    _binary_op(class boost::shared_ptr<class Mantid::API::MatrixWorkspace>, class boost::shared_ptr<class Mantid::API::MatrixWorkspace>, class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >, class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >, bool, bool)" in file 'MantidFramework.py' at line 459


This is true for +,-,/,*, Divide(‘I’,’Io’,’R’), Divide(‘I’,’Io’,’R’,AllowDifferentNumberSpectra=True),

and another

The following simple script fails.
###########################################
FileName="D:/data/cycle_11_2/POLREF00004711.raw"
Load(Filename=FileName,OutputWorkspace="_Raw")
ConvertUnits(InputWorkspace="_Raw",OutputWorkspace="_Raw",Target="Wavelength
")
NormaliseToMonitor(InputWorkspace="_Raw",OutputWorkspace="_D",MonitorSpectru
m="3")
###########################################

Fails with error:

Algorithm: NormaliseToMonitor v1
Parameters:
  Name: InputWorkspace, Value: _Raw_1, Default?: No, Direction: Input
  Name: OutputWorkspace, Value: _D_1, Default?: No, Direction: Output
  Name: MonitorSpectrum, Value: 3, Default?: No, Direction: Input
  Name: MonitorWorkspace, Value: _Raw_1, Default?: No, Direction: Input
  Name: IntegrationRangeMin, Value: 8.9884656743115785e+307, Default?: Yes,
Direction: Input
  Name: IntegrationRangeMax, Value: 8.9884656743115785e+307, Default?: Yes,
Direction: Input
  Name: IncludePartialBins, Value: 0, Default?: Yes, Direction: Input Error in execution of algorithm NormaliseToMonitor Only one of the MonitorSpectrum and MonitorWorkspace properties should be set Error in execution of algorithm NormaliseToMonitor execution failed for the input workspace _Raw_1

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Martyn Gigg]

Two comments here:

Problem 1) Is an issue with BinaryOperation only accepting MatrixWorkspace types and would be too major a change for so late in the testing change. Ticket #3778 addresses this.

Problem 2) Is a problem with the processGroups method in Algorithm.cpp. Yet again another core component that I don't think we should change now. The issue is that processGroups sets ALL input workspaces its child algorithm so for things like NormaliseToMonitor example herethis causes it to fail as you end up setting properties that weren't set on the original algorithm. I have added this as part of #3760 as it is related.

This ticket will be marked as wontfix as the issues will be covered by other tickets in the next iteration

[Janik Zikovsky]

Okay.

[Stuart Campbell]

This ticket has been transferred to github issue ​4542