Ticket #3761 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

WorkspaceGroups with invalid members for a given property still appear in the allowedValues list

Reported by: Martyn Gigg Owned by: Peter Parker
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Linked to #2948.

The allowedValues list still returns WorkspaceGroup objects since isValid doesn't check whether the all members of valid or not. To do this some of the code is going to have to be moved around so that each member can be checked without isValid without affecting the value of the property.

It was considered too much work with a core class for iteration 30.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone
  • Priority changed from major to critical

comment:2 Changed 9 years ago by Peter Parker

  • Priority changed from critical to major
  • Owner changed from Anyone to Peter Parker
  • Status changed from assigned to accepted

comment:3 Changed 9 years ago by Peter Parker

Now excluding WorkspaceGroups from the allowedValues list who's entire contents are not all of the correct type. Refs #3761.

Changeset: d42bf036b3f952ba29466b58800b838ba172f57d

comment:4 Changed 9 years ago by Peter Parker

The members of WorkspaceGroups are now validated. Refs #3761.

Changeset: c0e8b95ab1e08a55500e794fa1b83f4da62809eb

comment:5 Changed 9 years ago by Peter Parker

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Peter Parker

The members of WorkspaceGroups are now validated. Refs #3761.

Changeset: c0e8b95ab1e08a55500e794fa1b83f4da62809eb

comment:7 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:8 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

I've tested with the CorrectKiKf algorithm. If all workspaces in the group are in units of DeltaE, it shows up in th allowed list. If one is TOF, and 2 are DeltaE, it does not show up

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4608

Note: See TracTickets for help on using tickets.