Ticket #1357 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Make DiffractionFocussing work with EventWorkspace

Reported by: Peter Peterson Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 24
Component: Keywords: event
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Rather than letting the histogram representation make the magic happen, DiffractionFocussing will be modified to work with EventWorkspace

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [5061]) Refs #1267 and #1357: had to add some const versions of methods.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [5063]) Refs #1357 - calibration data needed for the test.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [5064]) Refs #1357 - EventWorkspace diffraction focussing.

comment:5 Changed 10 years ago by Nick Draper

(In [5124]) Extended EventList to support calculation of Gaussian errors. Changed cache usage to not recalculate cached data if it was still valid, also separated calculation of Y cache from E cache, as E will be requested less often.

All of this was done to allow the addition of tests in DivideTest which required errors. re #1367, re #1357

comment:6 Changed 10 years ago by Peter Peterson

(In [5340]) Copying information from source workspace. Refs #1357.

comment:7 Changed 10 years ago by Janik Zikovsky

(In [5534]) Refs #1357: Diffraction focussing algorithm picks the first X axis as its default bins after summing up event lists. Results are reasonable-looking using PG3 data.

comment:8 Changed 10 years ago by Peter Peterson

(In [5593]) Updating calibration file. Refs #1357 and #1358.

comment:9 Changed 10 years ago by Janik Zikovsky

Bug: Logarithmic rebinning fails after diffraction focussing, for some reason.

comment:10 Changed 10 years ago by Janik Zikovsky

(In [5600]) Refs #1357: test added for PG3 data reduction, but weirdness happens in rebinning.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [5602]) Refs #1313: fixed a bug with Event histogramming when the first event TOF was smaller than the first bin. Also, should fix test build that refs #1357.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [5684]) Refs #1357: Trying to fix DiffractionFocussing test error.

comment:13 Changed 10 years ago by Janik Zikovsky

(In [5732]) Refs #1357 - changed DiffractionFocussing with event workspaces so that an empty histogram is created even if one of the groups is empty (no events).

comment:14 Changed 10 years ago by Janik Zikovsky

(In [5733]) Refs #1357: Windows test fails, so I am disabling it for now (no way to check).

comment:15 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify

comment:16 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:17 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:18 Changed 10 years ago by Nick Draper

  • Status changed from verifying to closed

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2204

Note: See TracTickets for help on using tickets.