Ticket #1368 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate the use of Workspace2D workspace properties

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

This is for input (or InOut) properties only. They should all be able to use MatrixWorkspace, even if the algorithm doesn't really make sense with 1D/single value workspaces. This will allow the algorithm to work with an EventWorkspace as input.

The following algorithms need to be looked at (although some will just have a Workspace2D in the output properties):

Algorithms/src/CalculateTransmission.cpp Algorithms/src/ConjoinWorkspaces.cpp Algorithms/src/ConvertSpectrumAxis.cpp Algorithms/src/CropWorkspace.cpp Algorithms/src/ExtractSingleSpectrum.cpp Algorithms/src/FindDeadDetectors.cpp Algorithms/src/GetEi.cpp Algorithms/src/NormaliseToMonitor.cpp Algorithms/src/SumSpectra.cpp DataHandling/src/GroupDetectors2.cpp DataHandling/src/GroupDetectors.cpp DataHandling/src/LoadDetectorInfo.cpp DataHandling/src/MaskDetectors.cpp DataHandling/src/MaskDetectorsInShape.cpp DataHandling/src/UpdateDAE.cpp Algorithms/src/FFT.cpp Algorithms/src/GroupWorkspaces.cpp Algorithms/src/MuonAsymmetryCalc.cpp Algorithms/src/PlotAsymmetryByLogValue.cpp Algorithms/src/Qxy.cpp Algorithms/src/ReadGroupsFromFile.cpp Algorithms/src/RenameWorkspace.cpp CurveFitting/src/Fit.cpp CurveFitting/src/FitMultispectral.cpp DataHandling/src/LoadAscii.cpp DataHandling/src/LoadDAE.cpp DataHandling/src/LoadEmptyInstrument.cpp DataHandling/src/LoadRaw2.cpp DataHandling/src/LoadRaw.cpp DataHandling/src/LoadRawHelper.cpp DataHandling/src/SaveAscii.cpp Nexus/src/LoadISISNexus2.cpp Nexus/src/LoadISISNexus.cpp Nexus/src/LoadMuonNexus2.cpp Nexus/src/LoadMuonNexus.cpp Nexus/src/LoadNeXus.cpp Nexus/src/LoadNexusProcessed.cpp

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Russell Taylor

(In [5120]) First batch of algorithms with Workspace2D workspace properties changed to MatrixWorkspace. Re #1368.

comment:3 Changed 10 years ago by Russell Taylor

(In [5121]) Checked in local changes by mistake. Re #1368.

comment:4 Changed 10 years ago by Russell Taylor

(In [5129]) Eliminate Workspace2D input properties in CurveFitting. Re #1368.

comment:5 Changed 10 years ago by Russell Taylor

(In [5131]) More Workspace2D property eradication. Re #1368.

comment:6 Changed 10 years ago by Russell Taylor

(In [5142]) More Workspace2D hoovering. Re #1368.

comment:7 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:8 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:9 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:10 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2215

Note: See TracTickets for help on using tickets.