Ticket #1377 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Fitting: only fit peaks to a specified number of widths

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

for peak functions only calculate the fit to a specified number of peak widths as discussed.

Change History

comment:1 Changed 10 years ago by Roman Tolchenov

(In [5271]) Limited calculation of peaks to the area close to the peak centre. The size of the area (in FWHMs) is defined by CurveFitting.PeakRadius property. re #1377

comment:2 Changed 10 years ago by Roman Tolchenov

(In [5272]) Linux build fix. re #1377

comment:3 Changed 10 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 10 years ago by Roman Tolchenov

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:5 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:7 Changed 10 years ago by Janik Zikovsky

(In [5895]) Refs #1377: added line in test to confirm proper testing.

comment:8 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

comment:9 Changed 10 years ago by Russell Taylor

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:10 Changed 10 years ago by Russell Taylor

(In [5900]) Attempt to fix test failure. Re #1377.

comment:11 Changed 10 years ago by Russell Taylor

(In [5901]) Try again. Several of the other curvefitting tests set peakRadius to 100 and don't set it back when they're done. Re #1377.

comment:12 Changed 10 years ago by Russell Taylor

(In [5903]) Revert previous changes (one unintentional). Re #1377.

comment:13 Changed 10 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:14 Changed 10 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying

comment:16 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2224

Note: See TracTickets for help on using tickets.