Ticket #1408 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Implement algorithm to apply angle-dependent transmission correction

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Steve Williams

Description

The transmission correction algorithms currently implemented compute the transmission at theta=0. For shorter sample-detector distances, the transmission correction is a function of the transmission at theta=0 and the scattering angle.

Implement an algo that applies the angle-corrected transmission from the output of CalculateTransmission.

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Mathieu Doucet

(In [5284]) Added ApplyTransmissionCorrection + tests. Re #1408

comment:3 Changed 10 years ago by Mathieu Doucet

(In [5291]) Added test to check that we get the correct result even when the order of the monitors is not the spectrum/index order. Re #1408

comment:4 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:5 Changed 10 years ago by Mathieu Doucet

(In [5336]) Modified ApplyTransmissionCorrection to accept transmission value entered by hand. Re #1408

comment:6 Changed 10 years ago by Mathieu Doucet

(In [5337]) Fixed problem with ApplyTransmissionCorrection for when the output workspace is the input workspace. Re #1408

comment:7 Changed 10 years ago by Mathieu Doucet

(In [5338]) Updated documentation in header file. Re #1408

comment:8 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:9 Changed 10 years ago by Steve Williams

  • Status changed from verify to verifying
  • Tester set to Steve Williams

comment:10 Changed 10 years ago by Steve Williams

  • Status changed from verifying to reopened
  • Resolution fixed deleted

There is a strange problem with TransmissionValue is exactly 1 e.g. the following gives all 1s on my computer

Load(Filename="C:/mantid/Test/Data/SANS2D/BioSANS_test_data.xml",OutputWorkspace="bioSANS")
ApplyTransmissionCorrection(InputWorkspace="bioSANS",OutputWorkspace="bioTRANS",TransmissionValue="1")
Divide(LHSWorkspace="bioSANS",RHSWorkspace="bioTRANS",OutputWorkspace="test")

Might not be a problem because other values work OK. There is not wikipage yet at http://www.mantidproject.org/ApplyTransmissionCorrection The algorithm leaves all the x values at 0

comment:11 Changed 10 years ago by Mathieu Doucet

The correction goes like T(some factor). When T=1 there should be no correction.

The wiki page will be taken care of in Iteration 25 (see #1557)

comment:12 Changed 10 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

comment:13 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 10 years ago by Steve Williams

  • Status changed from verify to verifying

comment:15 Changed 10 years ago by Steve Williams

  • Status changed from verifying to closed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2255

Note: See TracTickets for help on using tickets.