Ticket #1409 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

WorkspaceHelpers::getIndicesFromSpectra doesn't preserve input list order

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

The WorkspaceHelpers::getIndicesFromSpectra function doesn't preserve the order of the spectra list it is given. The returned indices are always ordered from lowest to highest, which breaks at least one algorithm (CalculateTransmission).

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to accepted
  • Owner set to Mathieu Doucet

comment:2 Changed 10 years ago by Mathieu Doucet

(In [5289]) Preserve input spectra list order when creating list of corresponding indices. Re #1409

comment:3 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:4 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:5 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Passed, but see ticket #1521 for refactoring plan.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2256

Note: See TracTickets for help on using tickets.