Ticket #1416 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Separate off run information, logs etc, in to a Run class

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

Currently the Sample class holds data about the sample but also holds the run logs. This means that a user has to get hold of the Sample object to query the run data which is counter intuitive.

Create a separate Run class and move all non-Sample related information to this.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

(In [5309]) Created a new Run class to hold run information, logs etc. Added a test but not propagated its use out yet. Fixed a bug in property manager, that was found here, where removeProperty would cause a crash when the manager's destructor was run since it wasn't actually removing the entry from the property map. Updated the property manager test as a result. Re #1416

comment:2 Changed 10 years ago by Martyn Gigg

(In [5310]) Forgot to check in changes to Sample test. Re #1416

comment:3 Changed 10 years ago by Martyn Gigg

(In [5348]) Converted all uses of the logs on the Sample class to use the new Run class. Also cleared some warnings. Re #1416

comment:4 Changed 10 years ago by Martyn Gigg

(In [5349]) Checked in local modifications by accident. Re #1416

comment:5 Changed 10 years ago by Martyn Gigg

(In [5350]) Windows is unhappy with a compiler generated copy constructor. Added that and an assignment operator plus a test. Re #1416

comment:6 Changed 10 years ago by Michael Whitty

(In [5353]) re #1416 - adjusting solution/project files for Windows build in response to revision 5349

comment:7 Changed 10 years ago by Martyn Gigg

(In [5357]) Parsing ISIS run information from Raw and Nexus fields into new run object. Also fixed an with old getSampleDetails from Python. New method getSampleInfo now does this job. Re #1416

comment:8 Changed 10 years ago by Martyn Gigg

(In [5364]) Implemented run parameter reading for ISIS Nexus and Raw loading routines. Re #1416

comment:9 Changed 10 years ago by Martyn Gigg

(In [5370]) Modified Nexus processed routines to deal with single-valued log entries, previously these were only coping with time series logs. The sample geometry has been moved to single-valued entries instead of a time series but LoadNexusProcessed still checks for an entry as a time series. Re #1416

comment:10 Changed 10 years ago by Martyn Gigg

(In [5372]) Fix build. My version of gcc let this through but gcc44 and other don't. Re #1416

comment:11 Changed 10 years ago by Martyn Gigg

(In [5373]) Fix a test. Re #1416

comment:12 Changed 10 years ago by Martyn Gigg

(In [5374]) Fix windows build. Re #1416

comment:13 Changed 10 years ago by Martyn Gigg

(In [5388]) Fix for setting the proton charge. It's stored as a float in the Nexus file and trying to retrieve it as a double gives you zero. The unit test wasn't testing this as I thought it was. Updated it to do so. Re #1416

comment:14 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:15 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:16 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:17 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:18 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to closed

This was done correctly.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2263

Note: See TracTickets for help on using tickets.