Ticket #1416 (closed: fixed)
Separate off run information, logs etc, in to a Run class
Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Iteration 24 |
Component: | Keywords: | ||
Cc: | Blocked By: | ||
Blocking: | Tester: | Peter Peterson |
Description
Currently the Sample class holds data about the sample but also holds the run logs. This means that a user has to get hold of the Sample object to query the run data which is counter intuitive.
Create a separate Run class and move all non-Sample related information to this.
Change History
comment:9 Changed 10 years ago by Martyn Gigg
(In [5370]) Modified Nexus processed routines to deal with single-valued log entries, previously these were only coping with time series logs. The sample geometry has been moved to single-valued entries instead of a time series but LoadNexusProcessed still checks for an entry as a time series. Re #1416
comment:10 Changed 10 years ago by Martyn Gigg
comment:11 Changed 10 years ago by Martyn Gigg
comment:12 Changed 10 years ago by Martyn Gigg
comment:13 Changed 10 years ago by Martyn Gigg
comment:15 Changed 10 years ago by Martyn Gigg
- Status changed from accepted to testing
- Resolution set to fixed
comment:16 Changed 10 years ago by Nick Draper
- Status changed from testing to verify
Moved to verify state
comment:17 Changed 10 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:18 Changed 10 years ago by Peter Peterson
- Status changed from verifying to closed
This was done correctly.
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2263
(In [5309]) Created a new Run class to hold run information, logs etc. Added a test but not propagated its use out yet. Fixed a bug in property manager, that was found here, where removeProperty would cause a crash when the manager's destructor was run since it wasn't actually removing the entry from the property map. Updated the property manager test as a result. Re #1416