Move the Assign*() and Transmission*() code into a SANSReductionStep class

[Steve Williams]

Add the following commands into Mathieu's CommandInterface.py:

• AssignSample()
• TransmissionSample()
• AssignCan()
• TransmissionCan()
• SANS2D()
• LOQ()

All but the last two will be implemented in a class decended from SANSReductionStep, an instance of which will be added to a Reducer class instance. All run specific instument changes will be moved into this class and its interface will replace the _SAMPLE_SETUP _SAMPLE_RUN SCATTER_SAMPLE, SCATTER_CAN, TRANS_SAMPLE, TRANS_CAN, PERIOD_NOS, DIRECT_SAMPLE, DIRECT_CAN, DIRECT_CAN, _SAMPLE_N_PERIODS, _CAN_N_PERIODS, _TRANS_SAMPLE_N_PERIODS, DIRECT_SAMPLE_N_PERIODS, TRANS_SAMPLE_N_CAN, DIRECT_SAMPLE_N_CAN global variables and the RunDetails class.

The LOQ() and SAN2D() commands will be made to add LOQ and SANS2D Instrument instances to that Reducer.

This will also require:

• understanding and possible debugging of Mathieu's existing framework
• writing Python unit tests
• adapting the system tests and the GUI to allow testing by doing reductions with some functions imported from CommandInterface.py and some from SANSReduction.py

[Steve Williams]

Estimated total time 2 days.

There is uncertainty because Mathieu's framework is a bit complicated and under development. The task is complicated because the changes will touch a lot of the SANSReduction script and the C++ GUI.

0.5 days to write tests, adapt existing system tests and hand run the GUI, 0.5 days to fix problems from testing. 0.5 days to move the code into the ReductionStep class and write its interface, 0.5 days to change SANSReduction.py and SANSRunWindow.cpp to use this interface.

[Martyn Gigg]

M Gigg time estimate: 2 days

[Steve Williams]

(In [6061]) The SANS interface takes some time to load the instrument, deals with errors that come from the instrument not being completely loaded re #1447

[Mathieu Doucet]

(In [6070]) Added TransmissionCan and TransmissionSample.

[Steve Williams]

(In [6258]) Fix SANS bug by fully moving the marked detector functionality to the instrument class re #1447

[Steve Williams]

This was done by Mathieu in #1570

[Stuart Campbell]

duplicate.

[Stuart Campbell]

This ticket has been transferred to github issue ​2294