Ticket #1600 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Usability Changes in Indirect ConvertToEnergy

Reported by: Michael Whitty Owned by: Michael Whitty
Priority: major Milestone: Iteration 25
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Based on feedback from Mr Howells - various adjustments

Change History

comment:1 Changed 10 years ago by Michael Whitty

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Michael Whitty

(In [6082]) re #1600 - "Plot Raw" button now behaves more consistently with invalid input; Calibration file input is now switched between being "optional" depending on whether the "Use Calib" checkbox is checked so the ui won't flag it as invalid when the user doesn't wish to use one; RES output will now be plotted if the "Plot Result" is checked, otherwise the workspace will be cleared away; the "Run" button is now disabled on the Calibration tab to avoid possible confusion

comment:3 Changed 10 years ago by Michael Whitty

(In [6097]) re #1600 - adjusting the process of switching between direct/indirect to take into account both interfaces connect their own slot to the "Browse" button for saving location, so if a user had used (initialised) both interfaces, they would get two separate pop-ups asking for different things. the switching process now disconnects/reconnects the appropriate signals.

comment:4 Changed 10 years ago by Michael Whitty

(In [6110]) re #1600 - changing the manner in which the calibration file is calculated, adding messages to the Results Log at various points in the process (currently prefixed by ">>" so they can be filtered out/recognised easily).

comment:5 Changed 10 years ago by Michael Whitty

(In [6133]) re #1600 - adding "plot input" button to RES section of calibration tab, with some fiddling to the IndirectEnergyConversion.res() python function to accommodate this. adjusting ui to disable the calibration file input when "Use Calib" is not checked.

comment:6 Changed 10 years ago by Michael Whitty

(In [6261]) re #1600 and #1611 - various adjustments to the indirect cte/indirect analysis uis. adding parameter files for diffraction spectra with aim to developing support for these shortly (as part of indirectAnalysis initially), adjustment of layout so each tab on IDA has three checkboxes (Verbose, Plot, Save) consistently, though Verbose isn't done yet. Added plot functions to slice, elwin and absorption. adjustments to how validators appear on indirect CTE when they're not actually required. disabling tabs that don't fit the current analyser/reflection selection.

also adding some files to the 2010 VS project that were lacking and preventing building locally

comment:7 Changed 10 years ago by Michael Whitty

(In [6264]) re #1600 - missed new file in check-in [6261] (horrible name is necessary, I promise)

comment:8 Changed 10 years ago by Michael Whitty

(In [6388]) re #1600 and #1611 - adjusting handling of file locations for indirect CTE and indirectAnalysis UI also changing Fury calls to deal with new algorithm.

comment:9 Changed 10 years ago by Michael Whitty

(In [6546]) re #1600 - Indirect CTE will now update the browsing directories is user changes preferences

comment:10 Changed 10 years ago by Michael Whitty

  • Component set to MantidPlot

comment:11 Changed 10 years ago by Michael Whitty

(In [6668]) re #1600 - changing the way the run buttons are handled in the tabs of Indirect CTE interface, plus some minor changes to the python scripts.

comment:12 Changed 10 years ago by Michael Whitty

(In [6681]) re #1600 - indirect convert to energy to take monitor parameters (used in normalising to monitor) from instrument parameter file, rather than having it hard-coded into the scripts.

comment:13 Changed 10 years ago by Michael Whitty

(In [6718]) re #1600 - updating iris/osiris definition files

comment:14 Changed 10 years ago by Michael Whitty

(In [6721]) re #1600 - changes to IRIS IDF caused test failure.

comment:15 Changed 10 years ago by Michael Whitty

(In [6751]) re #1600 - indirect cte scripts - fix for save location of created file, modifying the whitespace to bring in line with PEP8 (sorry, was unaware we were following such guidelines for python)

comment:16 Changed 10 years ago by Michael Whitty

(In [6797]) re #1600 - adding osiris raw files for demo

comment:17 Changed 10 years ago by Michael Whitty

(In [6923]) re #1600 - adding range selector qwt plot to the "Diagnostics" tab in Indirect CTE interface

comment:18 Changed 10 years ago by Michael Whitty

(In [6993]) adding qwt plot picker to "calibration" tab of indirect cte. refs #1600

comment:19 Changed 10 years ago by Michael Whitty

(In [7032]) removing browse-to-save-directory from the indirect interface, as it's now redundant with the manage user directories the same number of clicks away. refs #1600

comment:20 Changed 10 years ago by Michael Whitty

(In [7033]) removing browse-to-save-directory from the indirect interface, as it's now redundant with the manage user directories the same number of clicks away. refs #1600 (missed this file on checkin [7032]

comment:21 Changed 10 years ago by Michael Whitty

(In [7065]) numerous small usability changes to indirect convert-to-energy and data-analysis user interfaces based on requests from Sp. refs #1600 and #1611

comment:22 Changed 10 years ago by Michael Whitty

(In [7068]) indirect convert to energy user interface, adding option for plotting of output (spectra, contour), changing SofQw tab to plot input as contour, and cleaning up it's handling of workspace names, also adding saving to sofqw tab. this refs #1600

comment:23 Changed 10 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

mark complete for this ticket, more will surely follow in next iteration

comment:24 Changed 10 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:25 Changed 10 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Changes made to interfaces looks good including plotting of S(Q,omega) (next release will see spectrum number being swapped with Q).

As a suggestion for future improvement when in 'Energy Transfer' tab e.g. instrument OSIRIS is selected and in the 'Calibration' tab a IRIS file is selected using the Browse button, then when plotted using the 'Plot Raw' button currently the Script Console is opened with an error message. MantidPlot does not crash but consider presenting the user with a more soft message.

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2447

Note: See TracTickets for help on using tickets.