Ticket #1601 (assigned)

Opened 10 years ago

Last modified 5 years ago

Improve code reuse for Parameters in ParameterMap

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.5
Component: Framework Keywords: Maintenance, Core
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Martyn Gigg) (diff)

The ParameterMap currently stores Geometry::Parameter objects as its value type. On the surface it seems that the Parameter type offers very little over and above the more standard Property classes used by Algorithms.

We should look at whether the Geometry::Parameter classes can just be replaced and their functionality implemented with Property types as this would benefit on code sharing. We can then remove the separate, getIntParameter, getStringParameter etc methods on the component and simply have getParameter that returns an appropriate object, which can also be used in Python.

There is also a hole in the current mechanism whereby we can't do anything with the FitParameter class as it doesn't inherit from anything.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Martyn Gigg
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:11 Changed 8 years ago by Martyn Gigg

  • Milestone changed from Release 2.4 to Release 2.5

comment:12 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:13 Changed 7 years ago by Martyn Gigg

  • Milestone changed from Release 2.6 to Release 2.7

Batch move to 2.7

comment:14 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:15 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.7 to Backlog

comment:16 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:17 Changed 6 years ago by Martyn Gigg

  • Keywords Maintenance, Core added
  • Summary changed from Cleanup parameter access from Python to Improve code reuse for Parameters in ParameterMap
  • Component set to Framework
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.4

comment:18 Changed 6 years ago by Martyn Gigg

  • Milestone changed from Release 3.4 to Release 3.5

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2448

Note: See TracTickets for help on using tickets.