Ticket #1644 (closed: fixed)
Simple Background Quantification
Reported by: | Nick Draper | Owned by: | Ronald Fowler |
---|---|---|---|
Priority: | major | Milestone: | Release 2.0 |
Component: | VATES | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Janik Zikovsky |
Description (last modified by Ronald Fowler) (diff)
Simple background energy model can be fitted for an MDWorkspace. Other models and foreground models will be done under new ticket.
Change History
comment:2 Changed 10 years ago by Janik Zikovsky
Oops - that last comment is supposed to be on ticket #1664. Please ignore for this ticket.
comment:4 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:6 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:10 Changed 10 years ago by Ronald Fowler
comment:11 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:12 Changed 9 years ago by Ronald Fowler
comment:13 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
"New" tickets moved at the code freeze of iteration 29
comment:14 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:15 Changed 9 years ago by Ronald Fowler
Refs #1644 - updating files to take into account new IMDWorkspace
Mainly updates to the QuadEnBackgroundTest.h file to set up a new IMDWorkspace to test. Not yet complete.
Changeset: d9637723420edfbc9c6615ecdb419c247363dbef
comment:16 Changed 9 years ago by Ronald Fowler
Adding MDEvent test workspace to SimulateMDDTest.h re #1644
Changeset: 4c7bde120d0af4ddf5c0f5239ecb675e106e8e86
comment:17 Changed 9 years ago by Ronald Fowler
More changes to allow MDEvent workspace to work with simple background
re #1644. Currently only works for an event workspace where "events" are really detector pixels. Small update to MDEventsTestHelper.h to add non-Lean MDEvents
Changeset: 9fb24531b781f6e06981f77a2fc8478f7757fd66
comment:18 Changed 9 years ago by Ronald Fowler
More updates for background fitting to MDEevents workspaces
Changed MDAlgorithms/CMakeLists.txt to re-include QuadEnBackground test and to include needed references to the curve fitting library to build this. QuadEnBackgroundTest.h changed to use MDEventWorkspace and remove old code. QuadEnBackground.cpp minor changes. Note this uses normalization by number of events, while fitting currently works on volume normalization. Latter needs changing. Re #1644
Changeset: 906ac37afe9dd7f77b4dc912311d388386be4151
comment:19 Changed 9 years ago by Ronald Fowler
Refs #1644 - updating files to take into account new IMDWorkspace
Mainly updates to the QuadEnBackgroundTest.h file to set up a new IMDWorkspace to test. Not yet complete.
Changeset: d9637723420edfbc9c6615ecdb419c247363dbef
comment:20 Changed 9 years ago by Ronald Fowler
Adding MDEvent test workspace to SimulateMDDTest.h re #1644
Changeset: 4c7bde120d0af4ddf5c0f5239ecb675e106e8e86
comment:21 Changed 9 years ago by Ronald Fowler
More changes to allow MDEvent workspace to work with simple background
re #1644. Currently only works for an event workspace where "events" are really detector pixels. Small update to MDEventsTestHelper.h to add non-Lean MDEvents
Changeset: 9fb24531b781f6e06981f77a2fc8478f7757fd66
comment:22 Changed 9 years ago by Ronald Fowler
More updates for background fitting to MDEevents workspaces
Changed MDAlgorithms/CMakeLists.txt to re-include QuadEnBackground test and to include needed references to the curve fitting library to build this. QuadEnBackgroundTest.h changed to use MDEventWorkspace and remove old code. QuadEnBackground.cpp minor changes. Note this uses normalization by number of events, while fitting currently works on volume normalization. Latter needs changing. Re #1644
Changeset: 906ac37afe9dd7f77b4dc912311d388386be4151
comment:23 Changed 9 years ago by Ronald Fowler
Updates to background fit testing re #1644
Updated QuadEnBackgroundTest to check simple use of CompositeFunctionMD. Also updated Iterators to add methods getSignal() and getError() to get the sum of these values without volume normalization. This is needed in Tobyfit for normalization by the number of detector bins contributing to the signal, i.e. getSignal()/getNumEvents().
Changeset: d8afed6cd815049da15cdc90b3be7f880ea39850
comment:24 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:26 Changed 9 years ago by Ronald Fowler
- Status changed from accepted to verify
- Resolution set to fixed
- Description modified (diff)
- Milestone changed from Iteration 33 to Iteration 32
comment:27 Changed 9 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
comment:28 Changed 9 years ago by Janik Zikovsky
Refs #1644: IFunctionMD made to use IMDIterator->getDataSize() ...
instead of relying on dimensions, since that implies regular binning. Took out MDEventsTestHelper method that were added to make it work anyway. WARNING: It looks like the copy of the data made by the IFunctionMD::setWorkspace() method is of it->getNormalizedSignal(); whereas the QuadEnBackground function uses the # of events normalization. This will cause a problem. Commented out a test that was now failing.
Changeset: 0af68dc483c92845b3f230e2e561b67e33241750
comment:29 Changed 9 years ago by Janik Zikovsky
- Status changed from verifying to closed
The scope of the work in the ticket, iterator with number of events, is complete. However, remaining issue pointed out in ticket #4468.
comment:30 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2491
(In [6527]) Refs #1644: Added the NOT and PLUS operators for filters. Added full test.