Ticket #1647 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Modify Direct Geometry Inelastic scripts and GUI to work for SNS instruments

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

This is following on from ticket #1491

Change History

comment:1 Changed 10 years ago by Stuart Campbell

(In [6169]) Added Tzero as an argument to main convert_to_energy method. refs #1647

comment:2 Changed 10 years ago by Stuart Campbell

(In [6171]) Added Tzero text input field. refs #1647

comment:3 Changed 10 years ago by Stuart Campbell

(In [6172]) Added passing the Tzero value to python. refs #1647

comment:4 Changed 10 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:5 Changed 10 years ago by Stuart Campbell

This has subtickets: #1860, #1861, #1862, #1863, #1864, #1865, #1866, #1867

comment:6 Changed 10 years ago by Stuart Campbell

And another #1880

comment:7 Changed 10 years ago by Stuart Campbell

Ticket for making Abs units more useful #1897

comment:8 Changed 10 years ago by Stuart Campbell

(In [7406]) Added cases for event nexus files. refs #1647

comment:9 Changed 10 years ago by Stuart Campbell

(In [7409]) Add ability to use event NeXus files. Make SNS instruments perform detector efficiency and Ki/Kf corrections. refs #1647

comment:10 Changed 10 years ago by Stuart Campbell

(In [7427]) Corrected problem with order of parameters for Abs Norm. Only perform Absolute units norm if a white van is specified on the last tab. refs #1647

comment:11 Changed 10 years ago by Stuart Campbell

(In [7605]) Quick fix to get around filenames are now a list. refs #1647

comment:12 Changed 10 years ago by Stuart Campbell

(In [7645]) Updates to make scripts work for SNS instruments. refs #1922 and #1647

comment:13 Changed 10 years ago by Stuart Campbell

(In [7886]) Don't call GetEi for SNS instruments if the Ei is fixed. refs #1647

comment:14 Changed 10 years ago by Stuart Campbell

(In [7996]) Added logic to use a different input to calculate the background if we are using events. refs #1647

comment:15 Changed 10 years ago by Stuart Campbell

(In [8037]) Do the background subtraction for events properly. refs #1647

comment:16 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:18 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

T0 problem as in ref #1861 Can you change Fix Ei label? It is completely unintuitive about what it does. Maybe to "Adjust Ei" or "Calculate Ei"

comment:19 Changed 10 years ago by Stuart Campbell

But it does fix the Ei ? "Adjust Ei" and "Calculate Ei" implies that it will do a calculation if you check it - which it won't

comment:20 Changed 10 years ago by Stuart Campbell

  • Status changed from reopened to accepted

comment:21 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8184]) Fixed logic with fixing Ei and actually retrieve T0 from GetEi algorithm now. fixes #1861 & #1647

comment:22 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:23 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to closed

Works with SEQUOIA data, uses the correct t0, and FixEi means that it uses the guess

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2494

Note: See TracTickets for help on using tickets.