Ticket #1861 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Ensure that the GetEI/Tzero is working correctly from the ConvertToEnergy GUI for SNS instruments

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Need to ensure that the correct method for getting Ei/T0 is done for each beamline.

Also, that the T0 is applied differently for SNS that ISIS beamlines.

This may want to be a 'tunable' parameter.

Change History

comment:1 Changed 10 years ago by Stuart Campbell

  • Owner set to Stuart Campbell
  • Status changed from new to accepted

comment:2 Changed 10 years ago by Stuart Campbell

(In [7594]) Add Tzero as an additional output property. refs #1861

comment:3 Changed 10 years ago by Stuart Campbell

(In [7595]) Make the same case as the other tests. refs #1861

comment:4 Changed 10 years ago by Stuart Campbell

(In [7596]) Make the same case as the other tests. refs #1861

comment:5 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

At the moment it returns a value that is consistent with one of the methods used at the SNS, but not the default one.

The work to make GetEi more robust and correct is in ticket #1923

comment:6 Changed 10 years ago by Andrei Savici

  • Status changed from verify to reopened
  • Resolution fixed deleted

In the Convert to energy, for SEQUOIA, T0 is not shifted

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:8 Changed 10 years ago by Andrei Savici

I think Stuart already has the fix. Must move back to Iteration 26

comment:9 Changed 10 years ago by Stuart Campbell

  • Milestone changed from Iteration 27 to Iteration 26

comment:10 Changed 10 years ago by Stuart Campbell

  • Status changed from reopened to accepted

comment:11 Changed 10 years ago by Stuart Campbell

(In [8183]) Add debugging message to print T0. refs #1861

comment:12 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8184]) Fixed logic with fixing Ei and actually retrieve T0 from GetEi algorithm now. fixes #1861 & #1647

comment:13 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:14 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to closed

Works as expected. Elastic line is at 0meV

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2708

Note: See TracTickets for help on using tickets.