Ticket #1701 (closed: fixed)
Fix conversion issue in ConvertUnits for EventWorkspaces
Reported by: | Michael Reuter | Owned by: | Michael Reuter |
---|---|---|---|
Priority: | major | Milestone: | Iteration 25 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Michael Whitty |
Description
There is an issue with doing multiple conversions through DeltaE with EventWorkspaces. The following conversion path: TOF->DeltaE->Other breaks on the second conversion complaining that EFixed cannot be zero. This is inspite of seeing a non-zero EFixed appear in the information messages. The code introduced in [6479] appears to be the cause of the breakage. Somehow, the logic for convertViaTOF and convertViaEventsTOF were made to be handled in a different manner. The needEfixed clause is what causes the break in the second conversion step for EventWorkspaces. Since DeltaE is the start, a fixed energy is necessary to complete the conversion. The clause causes the fixed energy to be set to zero since the target conversion is not DeltaE. The clause needs to be removed.
Attachments
Change History
comment:1 Changed 10 years ago by Michael Reuter
- Owner set to Michael Reuter
- Status changed from new to accepted
Changed 10 years ago by Michael Reuter
- Attachment test_2stepconvev_bug.py added
Testing script for EventWorkspaces two step conversion via DeltaE
comment:3 Changed 10 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
To test this ticket, the unit test for ConvertUnits should work. For completeness, the attached script can be run. It should run to completion without producing an error at the second conversion.
comment:4 Changed 10 years ago by Michael Whitty
- Status changed from verify to verifying
- Tester set to Michael Whitty