Ticket #1701 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Fix conversion issue in ConvertUnits for EventWorkspaces

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

There is an issue with doing multiple conversions through DeltaE with EventWorkspaces. The following conversion path: TOF->DeltaE->Other breaks on the second conversion complaining that EFixed cannot be zero. This is inspite of seeing a non-zero EFixed appear in the information messages. The code introduced in [6479] appears to be the cause of the breakage. Somehow, the logic for convertViaTOF and convertViaEventsTOF were made to be handled in a different manner. The needEfixed clause is what causes the break in the second conversion step for EventWorkspaces. Since DeltaE is the start, a fixed energy is necessary to complete the conversion. The clause causes the fixed energy to be set to zero since the target conversion is not DeltaE. The clause needs to be removed.

Attachments

test_2stepconvev_bug.py​ (559 bytes) - added by Michael Reuter 10 years ago.
Testing script for EventWorkspaces two step conversion via DeltaE

Change History

comment:1 Changed 10 years ago by Michael Reuter

  • Owner set to Michael Reuter
  • Status changed from new to accepted

comment:2 Changed 10 years ago by Michael Reuter

(In [6585]) Fixing issue with two step conversion via DeltaE for EventWorkspaces. Also, adding a unit test to check this in the future. This refs #1701.

Changed 10 years ago by Michael Reuter

Testing script for EventWorkspaces two step conversion via DeltaE

comment:3 Changed 10 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

To test this ticket, the unit test for ConvertUnits should work. For completeness, the attached script can be run. It should run to completion without producing an error at the second conversion.

comment:4 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:5 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

works in [7139]. there's a lot of copied & pasted code in the convert units algorithm between normal and events workspaces, which I think would benefit from refactoring.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2548

Note: See TracTickets for help on using tickets.