Ticket #1731 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS GUI: Add error checking to script generation

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

For the HFIR SANS GUI, add error checking so that the reduction or Mantid script export won't proceed if the input data is invalid. Each BaseScriptElement class should be responsible for their own inputs.

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

(In [6800]) Added basic error checking. Re #1731

comment:2 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:3 Changed 10 years ago by Mathieu Doucet

(In [6936]) Added error checking for empty input files. Re #1731

comment:4 Changed 10 years ago by Mathieu Doucet

(In [6940]) Added debug mode option to Tools menu to get full error stack. Re #1731

comment:5 Changed 10 years ago by Mathieu Doucet

(In [6964]) Fixed bug with sensitivity correction. Re #1731

comment:6 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

All text fields should now be checked. Numerical values are not but are validated by the UI.

comment:7 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Priority changed from major to minor
  • Resolution fixed deleted
  • Milestone changed from Iteration 25 to Iteration 26

I think the error reporting could be improved here. While it does pop up a box when, for example you enter an invalid filename, it's not clear which box it relates to and the error message only gives a directory.

To reproduce, just open the interface type in a non-existent path and click okay. The box should pop up containing only a directory portion of the path. Maybe consider marking the boxes that are invalid as we do with the red stars?

I'm reopening and assigning this to iteration 26 as minor given that you can't actually execute the reduction and it's more of an aesthetic thing.

comment:9 Changed 10 years ago by Mathieu Doucet

  • Milestone changed from Iteration 26 to Iteration 27

comment:10 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:11 Changed 10 years ago by Mathieu Doucet

(In [10225]) Make sure that the wavelength is either supplied or in the data file. Re #1731

comment:12 Changed 10 years ago by Mathieu Doucet

(In [10228]) Better error reporting. Re #1731

comment:13 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:14 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:15 Changed 9 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

Between the error reporting, the validators of the UI, and the recent addition of file path validation for all reduction commands should be enough checking. Calling this fixed.

comment:16 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:18 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed with several mistakes I've made that the reduction process displays errors correctly.

Also an attempt to set invalid input file paths raises errors.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2578

Note: See TracTickets for help on using tickets.