Ticket #1733 (closed)

Opened 10 years ago

Last modified 5 years ago

Some issues with the algorithm cancellation and progress reporting.

Reported by: Sofia Antony Owned by: Roman Tolchenov
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

1)Since the progress dialog was removed it's now impossible to cancel algorithms that are very fast using the Details Algorithms Progress dialog cancel button.

2)When loading multi period raw file if click cancel nothing happens

3)Progress reporting disappears when the Algorithms docking window is closed.However, users may run algorithms from the Script window or Workspaces window even if Algorithms window is not visible.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:5 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:6 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to closed
  • Resolution set to fixed

In [13074]:

1) I don't think anything should be done here as fast algorithms may not be possible to cancel anyway.
2) Made Algorithm::cancel() method virtual and overridden it in Load to call cancel() on the concrete loader. A test file can be sans2d00005512.nxs.
3) MantidPlot makes sure that the AlgorithmDockWidget is visible when an algorithm is running. fixes #1733

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from closed to verify
  • Resolution fixed deleted

Corrected status to verify

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:9 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

1) I agree that it is pointless to try and attempt to cancel a very fast algorithm, if it's very fast then it's over before you've realised you need to cancel it anyway.

Verified that the cancel seems to work effectively with the loaders now.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2580

Note: See TracTickets for help on using tickets.