Ticket #1761 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

GetDetectorOffsets has nonzero offset for spectra with no counts

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Crosscorrelation of reference peak and spectra with all zeros is nan. Check if peak height of Crosscorrelation is nan and return 0 for offset if true.

Change History

comment:1 Changed 10 years ago by Vickie Lynch

(In [6903]) Refs #1761 GetDetectorOffsets: return 0 if peak height of crosscorrelation is nan

comment:2 Changed 10 years ago by Vickie Lynch

  • Status changed from new to verify
  • Resolution set to worksforme

comment:3 Changed 10 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:4 Changed 10 years ago by Stuart Campbell

  • Status changed from verifying to verify
  • Tester Stuart Campbell deleted

comment:5 Changed 10 years ago by Vickie Lynch

(In [7158]) Refs #1761 Simpler test for GetDetectorOffsets

comment:6 Changed 10 years ago by Stuart Campbell

Just wondering, should this have been closed as fixed rather than worksforme ?

comment:7 Changed 10 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:8 Changed 10 years ago by Vickie Lynch

Yes, should have closed as fixed.

comment:9 Changed 10 years ago by Stuart Campbell

  • Status changed from verifying to reopened
  • Resolution worksforme deleted

comment:10 Changed 10 years ago by Stuart Campbell

  • Status changed from reopened to accepted
  • Owner changed from Vickie Lynch to Stuart Campbell

comment:11 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 10 years ago by Stuart Campbell

  • Status changed from verify to assigned
  • Owner changed from Stuart Campbell to Vickie Lynch

comment:13 Changed 10 years ago by Vickie Lynch

  • Status changed from assigned to accepted

comment:14 Changed 10 years ago by Vickie Lynch

  • Status changed from accepted to verify

comment:15 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:16 Changed 10 years ago by Vickie Lynch

  • Status changed from reopened to accepted

comment:17 Changed 10 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:18 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Stuart Campbell to Martyn Gigg

comment:19 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that the offsets are zero when run with a workspace containing only zeroes.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2608

Note: See TracTickets for help on using tickets.