Ticket #1911 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate the use of Merlin files in unit tests.

Reported by: Russell Taylor Owned by: Martyn Gigg
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

This is part of the drive to reduce the size of our subversion repository and elimate the reading of data files in unit tests unless absolutely necessary.

MER02257.raw and merlin_detector.sca are the second and third largest files currently used in unit tests.

Their use features in:

  • getEitest
  • SetScalingPSDrawtest
  • SetScalingPSDtest

Tests that have to load a file (i.e. those testing file loading algorithms) should switch to using a much smaller file. Others should create fictional data by using routines like WorkspaceCreationHelper.hh. If an algorithm under test requires the instrument geometry in any way then you may have to wait for completion of ticket #1899.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Martyn Gigg

comment:2 Changed 10 years ago by Russell Taylor

While you're at it, please also lose MAP10266 from getEiTest. It's 111MB, but I only spotted its use when it was moved into AutoTestData after I created the ticket.

If you're so inclined, you could lose the use of the MARI files in getEitest at the same time. Otherwise, someone will get the task later as we work down the list towards the smaller data files.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:4 Changed 10 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:5 Changed 10 years ago by Martyn Gigg

(In [8456]) Remove MERLIN and MARI raw files from unit test usage in GetEi, which is now raw file independent. Removed reference to mari and maps from LoadDetectorInfo and a small tidy to remove a temp file from DiffractionEventReadDetCalTest. Re #1911

comment:6 Changed 10 years ago by Martyn Gigg

(In [8463]) Remove reference to MERLIN test files from SetScalingPSD test in preference for a simple one that is written and removed with the test. Re #1911

comment:7 Changed 10 years ago by Martyn Gigg

(In [8467]) Slight relaxation of difference criteria from win32. Re #1911

comment:8 Changed 10 years ago by Martyn Gigg

(In [8481]) Remove final reference to the MERLIN file in the AutoTestData directory. Switched to using a much smaller MARI file for the RAW part of the SetScalingPSD test. Removed unused MERLIN and MARI files from AutoTestData. Re #1911

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 10 years ago by Russell Taylor

(In [8503]) Remove no-longer-used MAPS raw file. Re #1911.

comment:11 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:12 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

MER* and MAP* test files are not in autotest data, and tests pass.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2758

Note: See TracTickets for help on using tickets.