Ticket #1912 (closed: fixed)
Eliminate the use of GEM38370.raw in unit tests
Reported by: | Russell Taylor | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | major | Milestone: | Iteration 26 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description
This is part of the drive to reduce the size of our subversion repository and elimate the reading of data files in unit tests unless absolutely necessary.
GEM38370 is the joint fourth largest file currently used in unit tests.
Their use features in:
- FilePropertyTest
- IkedaCarpenterPVTest
- RawFileInfoTest
- LoadNexusProcessedTest
Tests that have to load a file (i.e. those testing file loading algorithms) should switch to using a much smaller file. Others should create fictional data by using routines like WorkspaceCreationHelper.hh. If an algorithm under test requires the instrument geometry in any way then you may have to wait for completion of ticket #1899.
Change History
comment:2 Changed 10 years ago by Nick Draper
- Owner set to Anders Markvardsen
- Status changed from new to assigned
comment:3 Changed 10 years ago by Anders Markvardsen
(In [8060]) Removed GEM38370.raw test from IkedaCarpenterTest with the description:
/* This test is basically a repeat of the test testAgainstGEM_data(). However I had various
problems with getting the saved nexus focused GEM to work probably in that test hence this test repeats testAgainstGEM_data() but directly from focused data in C++ */
Loaded data from Nexus now works hence the above test no longer serve a purpose.
No occurance of GEM38370.raw found in LoadNexusProcessedTest.
Substituted the use GEM38370 with LOQ48127 (the smallest raw file in the svn) in RawFileInfoTest and FilePropertyTest
re #1912
comment:5 Changed 10 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 10 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor