Ticket #2014 (closed: wontfix)
NormaliseToMonitor: Handle event workspaces better
Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
---|---|---|---|
Priority: | major | Milestone: | Iteration 27 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Nick Draper |
Description
Change History
comment:2 Changed 10 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
comment:3 Changed 10 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:4 Changed 10 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
The problem with this, apart from the fact that it can potentially take an age to run, is that it does not give the same answer as when run on the equivalent Workspace2D. This is because of the funky normalisation factor applied in the latter case - it's not a straight divide because of an original requirement that the output workspace was not dimensionless.
This will probably require some discussion. I'd suggest that it's not urgent and could wait until after the release.
comment:6 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:7 Changed 10 years ago by Janik Zikovsky
- Status changed from reopened to verify
- Resolution set to fixed
comment:8 Changed 10 years ago by Janik Zikovsky
- Status changed from verify to reopened
- Resolution fixed deleted
Sorry, this was supposed to go to #2104.
comment:10 Changed 10 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to wontfix
Someone who know how this normalisation is supposed to be done should fix this. The algorithm should just call Divide instead of reproducing that functionality; the event-ishness will come from that naturally.
comment:11 Changed 10 years ago by Janik Zikovsky
comment:12 Changed 10 years ago by Nick Draper
- Status changed from verify to verifying
- Tester changed from Russell Taylor to Nick Draper
comment:13 Changed 10 years ago by Nick Draper
- Status changed from verifying to closed
Verified by code investigation
v1.1.9448
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2861