Ticket #2337 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Extend the run file widget and use in the SANS GUI

Reported by: Steve Williams Owned by: Steve Williams
Priority: major Milestone: Iteration 28
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

The run file widget must be able to optionally deal with multi-entry workspaces. If "-add" is added to the end of a run number this must be added to the end of the filename to load.

The SANS GUI will then beable to accept file names as well as run numbers. There will be an option for multi-period entry boxes.

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Steve Williams

(In [9075]) The run files widget now has optional workspace entry selection boxes. It now checks if a non-run files exists and looks for files less frequently to lock the GUI less re #2337

comment:3 Changed 10 years ago by Steve Williams

(In [9084]) File widget improvements re #2337

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:5 Changed 10 years ago by Steve Williams

(In [9810]) File widget has new options to have a small browse for file icon instead of a button or neither one re #2337

comment:6 Changed 10 years ago by Steve Williams

(In [9974]) Run numbers entered into a RunFile widget ending in "-add" will cause a file whose name ends in -add to be loaded. Fix system tests re #2612 and #2337

comment:7 Changed 10 years ago by Stuart Campbell

Steve, just a suggestion/comment.

At the moment we (as in the US) are in the position where all our files have custom suffixes. Up until now, we are just specifying them as part of the extension so the File Finder can locate them. It is probably better to handle them separately as you have, but wouldn't the list of allowed extensions be facility or even beamline specific? Might it be a good idea to have these extensions listed in the facilities XML file?

comment:8 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

Stuart's suggestion has moved into ticket #2674

comment:9 Changed 9 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:10 Changed 9 years ago by Michael Whitty

  • Status changed from verifying to reopened
  • Resolution fixed deleted

when entering a run number with "-add", such as "54431-add" into the Sample box, I get the following error:

Sorry, MantidPlot has caught an unexpected exception:

bad lexical cast: source type value could not be interpreted as target

Would you like to terminate MantidPlot or try to continue working?
If you choose to continue it is advisable to save your data and restart the application.
---------------------------
Terminate   Continue   
---------------------------

comment:11 Changed 9 years ago by Steve Williams

(In [11106]) Remove a bug that occurred in ISIS SANS some times re #2337

comment:12 Changed 9 years ago by Steve Williams

(In [11114]) Improve error handling re #2337

comment:13 Changed 9 years ago by Steve Williams

(In [11126]) fix centre finding bug re #2337

comment:14 Changed 9 years ago by Steve Williams

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [11175]) Allow file finder to find '-add' files again fixes #2337

comment:15 Changed 9 years ago by Steve Williams

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:16 Changed 9 years ago by Steve Williams

(In [11177]) Fix the test re #2337

comment:17 Changed 9 years ago by Martyn Gigg

(In [11182]) Fix FileFinder test on Linux. Refs #2337

comment:18 Changed 9 years ago by Steve Williams

  • Status changed from reopened to accepted

comment:19 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester changed from Michael Whitty to Stuart Campbell

comment:21 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

It does give lots of nasty error messages if you facility is not set to ISIS before you launch the GUI.

Added some files together to produce a "-add" file. then reduced this. Seems to be ok.

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3184

Note: See TracTickets for help on using tickets.