Ticket #2474 (closed: fixed)
Make GroupDetectors accept GroupingWorkspace as a parameter
| Reported by: | Peter Peterson | Owned by: | Nick Draper |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Wenduo Zhou |
Description (last modified by Arturs Bekasovs) (diff)
Currently it accepts a file only, which is not very useful if we to apply grouping stored in the GUI or in memory. GroupingWorkspace object has all the information we need to do that.
Change History
comment:2 Changed 9 years ago by Janik Zikovsky
- Owner set to Janik Zikovsky
- Status changed from new to accepted
comment:4 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to new
With the SaveCalFile algorithm, we can load and save GroupingWorkspaces. Will leave the job of coming up with a better file format for later.
comment:5 Changed 9 years ago by Janik Zikovsky
- Milestone changed from Iteration 29 to Iteration 30
Moved my tickets that won't get finished by iteration 29
comment:6 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:7 Changed 9 years ago by Janik Zikovsky
- Status changed from new to assigned
- Owner changed from Janik Zikovsky to Anyone
comment:8 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:9 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:10 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:11 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:12 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.5
Moved at the code freeze for release 2.4
comment:13 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:15 Changed 7 years ago by Martyn Gigg
- Keywords Student, Challenging, XML added; Student ? removed
comment:18 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:19 Changed 7 years ago by Nick Draper
- Owner changed from Anyone to Keith Brown
- Milestone changed from Backlog to Release 3.0
comment:20 Changed 7 years ago by Nick Draper
- Owner changed from Keith Brown to Arturs Bekasovs
- Description modified (diff)
comment:21 Changed 7 years ago by Arturs Bekasovs
- Cc anders.markvardsen@… added
- Keywords Student, Challenging, XML removed
- Description modified (diff)
- Summary changed from Grouping and masking files improvements to Make GroupDetectors accept GroupingWorkspace as a parameter
The part of this ticket concerning the schema was moved to #7712.
Speaking about the algorithms, there are already existing ones which work with the grouping XML files: LoadDetectorsGroupingFile and SaveDetectorsGrouping. There was a ticket created concerning the support of group naming for these algorithms: #7715
The only problem left, is that while we can load grouping to a GroupingWorkspace, there is no algorithm which would allow us to apply it to another workspace. The GroupDetectors looks like something we might use, so this task basically converts to making GroupDetectors accept GroupingWorkspace as another _optional_ parameter.
comment:22 Changed 7 years ago by Arturs Bekasovs
- Blocking 7557 added
(In #7557) Some stuff should be done before I can solve that one. When all the "Blocked by" tickets will get solved, I will be able to store all the information in GroupingWorkspace and string describing pairing, load and save all that information using LoadMuonDetectorsGroupingFile and SaveMuonDetectorsGrouping.
So instead of keeping the temporary file, when applying/saving grouping I will parse the information from the GUI to these data structures and use them instead.
comment:23 Changed 7 years ago by Arturs Bekasovs
- Blocking 7765 removed
- Blocked By 2474 added
This ticket will be much easier when #7765 is implemented. When it happens, I can easily do this one by just adding another parameter and calling appropriate function.
comment:30 Changed 7 years ago by Arturs Bekasovs
- Blocked By 7765 removed
Sorry for these blocking status changes, Trac had some strange internal error. Now it seems fine.
comment:31 Changed 7 years ago by Arturs Bekasovs
- Blocked By 7765 added
(In #7765) Sorry for these blocking status changes, Trac had some strange internal error. Now it seems fine.
comment:32 Changed 7 years ago by Arturs Bekasovs
- Milestone changed from Release 3.0 to Backlog
Will not have time for it in this iteration.
comment:34 Changed 7 years ago by Arturs Bekasovs
- Cc anders.markvardsen@… removed
- Owner changed from Arturs Bekasovs to Anyone
- Blocked By 2872, 7765 removed
I am not really keen on this one anymore, as I've solved the problem I was having in a different way.
Though it still sounds like a good thing to implement at some point, so leaving it with Anyone.
comment:35 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:36 Changed 6 years ago by Nick Draper
- Owner changed from Anyone to Nick Draper
- Status changed from assigned to verify
- Resolution set to invalid
This is now implemented as "copy grouping from"
comment:37 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:39 Changed 6 years ago by Nick Draper
- Milestone changed from Backlog to Release 3.4
moved to r 3.4 as tickets are closed
comment:40 Changed 5 years ago by Nick Draper
- Resolution changed from invalid to fixed
Somehow these slipped through without a resolution. Set to Fixed.
comment:41 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3321
Bulk move of tickets at the end of iteration 28