Ticket #2709 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

PDF Fourier Transform

Reported by: Wenduo Zhou Owned by: Nick Draper
Priority: major Milestone: Iteration 29
Component: Mantid Keywords: PDF
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Add Fourier transform of PDF to Framework/Algorithms

Change History

comment:1 Changed 10 years ago by Wenduo Zhou

(In [10273]) Added PDFFT for Fourier transform of PDF. Addresses #2709.

comment:2 Changed 10 years ago by Russell Taylor

(In [10282]) Fix Windows build. Re #2709.

comment:3 Changed 10 years ago by Wenduo Zhou

(In [10407]) Added DampSq and Chanded PDFFT. Refs #2709.

comment:4 Changed 10 years ago by Wenduo Zhou

  • Status changed from new to verify
  • Resolution set to fixed

(In [10410]) Changed DampSq.cpp to fix the broken build on windows. Fixes #2709

comment:5 Changed 10 years ago by Wenduo Zhou

(In [10427]) Changed PDFFT.cpp to remove internal result printout. Fixes #2709.

comment:6 Changed 9 years ago by Andrei Savici

I did not see a wiki page

comment:7 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:8 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Milestone changed from Iteration 28 to Iteration 29

My understanding is that this is not really finished yet. For a start there is no unit test. Moving to the next iteration.

comment:9 Changed 9 years ago by Russell Taylor

That should say: no unit test that does anything significant.

comment:10 Changed 9 years ago by Russell Taylor

(In [11179]) Commenting out the factory registration for these algorithms - will add back in after the release. Also changed the name of PDFFT to PDFFourierTransform. Re #2709.

comment:11 Changed 9 years ago by Russell Taylor

(In [11338]) Make these available again in the algorithm factory now the release is behind us. I'm not that keen on the algorithm name 'DampSq' though. Re #2709.

comment:12 Changed 9 years ago by Wenduo Zhou

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [12366]) Change PDFFT.h to reslove the conflict. Fixes #2709.

comment:13 Changed 9 years ago by Michael Whitty

(In [12375]) refs #2709 - fix build for msvc compiler

comment:14 Changed 9 years ago by Wenduo Zhou

(In [12399]) Changed PDFFT.cpp for better use, and LoadLogsForSNSPulsedMagnet. Fixes #2709.

comment:15 Changed 9 years ago by Wenduo Zhou

(In [12401]) Changed LoadLogsForSNSPulsedMagnet.cpp to fix break build on Mac OS. Fixes #2709.

comment:16 Changed 9 years ago by Wenduo Zhou

(In [12472]) Changed PDFFT.cpp to remove warnings. Fixes #2709.

comment:17 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester changed from Russell Taylor to Peter Peterson

comment:18 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • The properties RMax, DeltaR, Qmin, Qmax, and DebugMode need to be documented (in the property declarations) including the fact that Qmin and Qmax default to the data range.
  • The documentation for the InputWorkspace does not state that it can be in Q or d.
  • The printing that is hiding in #if 0 should be converted to logging at debug or trace level.
  • Remove the DebugMode property.
  • Rename OutputWorkspace0 and OutputWorkspace1 to be something meaningful. In other algorithms you will see one output workspace property and the algorithm generates two names.
  • Trim the Q(S(Q)-1) Q range to be that selected to be Fourier transformed.

Otherwise the algorithm appears to work as advertised. #3253 and #3254 mention work that still needs to be done but that can wait.

comment:19 Changed 9 years ago by Nick Draper

  • Owner changed from Wenduo Zhou to Nick Draper
  • Status changed from reopened to accepted

#3286 created to cover these issues in the next iteration

comment:20 Changed 9 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:21 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester changed from Peter Peterson to Owen Arnold

comment:22 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Problems identified by P Peterson in spawned ticket #3286

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3556

Note: See TracTickets for help on using tickets.