Ticket #2797 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

MDEventWorkspace: centerpointBin(): support ImplicitFunction in binning.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: owen.arnold@… Blocked By:
Blocking: Tester: Owen Arnold

Description

... also refactor the method out of IMDEventWorkspace because Nick said so.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [10666]) Refs #2797: Moved centerpointBin... method and added an ImplicitFunction parameter (untested - I'm leaving that to Owen).

comment:3 Changed 10 years ago by Owen Arnold

(In [10682]) Hook-up implicit function. Tests that implicit function evaluate method is called. re #2797

comment:4 Changed 10 years ago by Owen Arnold

(In [10686]) Hook-up implicit function. Keep test out. re #2797

comment:5 Changed 9 years ago by Janik Zikovsky

(In [10771]) Refs #2797: If you pass an implicitFunction when binning to MDHistoWorkspace, bins that were not calculated are NaN.

comment:6 Changed 9 years ago by Janik Zikovsky

(In [10772]) Refs #2797: Fix test.

comment:7 Changed 9 years ago by Janik Zikovsky

(In [10774]) Refs #2797: Disable test because it fails on windows.

comment:8 Changed 9 years ago by Janik Zikovsky

  • Milestone changed from Iteration 28 to Iteration 29

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [11374]) Fixes #2797: This has been fixed for a little while, seems to work on Windows fine.

comment:10 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

This works. At present the only ImplicitFunction type passed through is a Plane. We have the flexibility to pass through many other types including compounds. Therefore suggest for future:

*Increase range of ImplicitFunction types that acutally get exercised (wont affect code here) *Improve performance using ImplicitFunctions. Currently call virtual evaluate function n-times.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3644

Note: See TracTickets for help on using tickets.