Ticket #3134 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MDBoxIterator: implement as a IMDIterator that goes through boxes.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Add useful methods for getting the IMDBox pointer, etc.

Filter to go only down to a given depth. Maybe filter by position in N dimensions.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

This will be useful for single-crystal peak finding.

comment:2 Changed 9 years ago by Janik Zikovsky

(In [12308]) Refs #3134: Stub of MDBoxIterator. Need to rework IMDIterator and others first.

comment:3 Changed 9 years ago by Janik Zikovsky

(In [12332]) Refs #3134: getBoxes() method on IMDBox is a whole lot simpler than messing with IMDIterator.

comment:4 Changed 9 years ago by Janik Zikovsky

(In [12754]) Fixes #3222: Bye-bye MDSplitBox. Also refs #3134.

comment:5 Changed 9 years ago by Janik Zikovsky

(In [12765]) Refs #3134: MDBoxIterator iterates through recursive boxes.

comment:6 Changed 9 years ago by Janik Zikovsky

(In [12766]) Refs #3134: Fix build.

comment:7 Changed 9 years ago by Janik Zikovsky

(In [12767]) Refs #3134: Windows test does not run, so disabled for now.

comment:8 Changed 9 years ago by Janik Zikovsky

(In [12769]) Refs #3134: Let's try that again.

comment:9 Changed 9 years ago by Janik Zikovsky

(In [12807]) Refs #3134: Iterator for 'leaves' only, with performance test.

comment:10 Changed 9 years ago by Janik Zikovsky

(In [12811]) Refs #3134: Trying to find cause of test failure on windows.

comment:11 Changed 9 years ago by Janik Zikovsky

(In [12812]) Refs #3134: Trying to find cause of test failure on windows.

comment:12 Changed 9 years ago by Janik Zikovsky

(In [12813]) Refs #3134: Trying to find cause of test failure on windows. Maybe the setup is the culprit?

comment:13 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12816]) Fixes #3134: Fix the windows test crash.

comment:14 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:15 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Tests passing. getBoxes seems like a good alternative solution. Full IMDIterators may still be useful.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3981

Note: See TracTickets for help on using tickets.