Ticket #3218 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

MDEventWorkspace: Determine extents automatically

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Find the smallest box that will hold all data.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [12742]) Fixes #3218: Automatic finding of extents of a MDEventWorkspace. 'Leaf' node finding.

comment:3 Changed 9 years ago by Janik Zikovsky

(In [12743]) Refs #3218: Added missing file. Sorry!

comment:4 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Functionality added + new tests pass. However, only vtkThresholdingHexahedronFactory.cpp modified to limit min and max signal values if they exceed the threshold limits. This adaption also needs to be applied to vtkThresholdingQuadFactory, vtkThresholdingLineFactory and vtkThresholdingUnstructuredGrid.

Either make these fixes as part of this ticket or reopen under a new ticket.

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:7 Changed 9 years ago by Janik Zikovsky

Thank Owen, will keep this ticket open for fixing in iteration 30.

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

I think there was a misunderstanding as to the scope of the ticket: this was to calculate the size (in X/Y/Z) of the workspace, and not the min/max signals. The work is complete as far as the X/Y extents determination goes.

comment:10 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester changed from Owen Arnold to Michael Reuter

comment:11 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

I think this is working OK as I have used the rebinner and it know the data extents without me having to know myself.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4065

Note: See TracTickets for help on using tickets.