Ticket #3219 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Create a property which does not store its value.

Reported by: Alex Buts Owned by: Andrei Savici
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

some properties in algorithms have to be correctly set to different values each time an algorithm is deployed. (e.g. phi in saveNXSPE algorithm)

Currently the property retains its value obtained from a previous run.

An property (or validator), which would not retain its(property) value and provide default value to the property, if nothing was specified as input to the property should be defined and used in such algorithms (e.g. -- saveNXSPE -- NaN for phi or Ei if nothing is specified as property value).

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

I think this is more a case for a validator than a property. And where it mentions storing it's value Alex means caching the last used value in the QSettings collection in Mantidplot.

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:9 Changed 8 years ago by Andrei Savici

  • Status changed from assigned to accepted
  • Owner changed from Anyone to Andrei Savici

comment:10 Changed 7 years ago by Andrei Savici

Forget property value. Refs #3219

Changeset: c4be6ab8d5d76cc42f97f1d237aeafa7762bac0d

comment:11 Changed 7 years ago by Andrei Savici

Branch feature/3219_forget_property. Not exposed to Python. To test modify an algorithm. I tried SetUB replaced 

    this->declareProperty(new PropertyWithValue<double>("a",1.0,mustBePositive,Direction::Input),"Lattice parameter a");

with 

    PropertyWithValue<double> *aprop=new PropertyWithValue<double>("a",1.0,mustBePositive,Direction::Input);
    aprop->setRemember(false);
    this->declareProperty(aprop,"Lattice parameter a");

In MantidPlot: Load a workspace, run SetUB, put values for a,b,c, say 3,3,3. Then run SetUB again. The algorithm has the values for b and c, but not for a

comment:12 Changed 7 years ago by Andrei Savici

Forget property value. Refs #3219

Changeset: c4be6ab8d5d76cc42f97f1d237aeafa7762bac0d

comment:13 Changed 7 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

Unit tests are missing.

comment:15 Changed 7 years ago by Andrei Savici

Remember property test. Refs #3219

Changeset: f860104a73c44e2a684c873fa2d05238a76ff5a4

comment:16 Changed 7 years ago by Andrei Savici

Remember property test. Refs #3219

Changeset: f860104a73c44e2a684c873fa2d05238a76ff5a4

comment:17 Changed 7 years ago by Andrei Savici

  • Status changed from reopened to accepted

comment:18 Changed 7 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:20 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

The property works as required. Ticket is closed.

comment:21 Changed 7 years ago by Andrei Savici

Forget property value. Refs #3219

Changeset: c4be6ab8d5d76cc42f97f1d237aeafa7762bac0d

comment:22 Changed 7 years ago by Andrei Savici

Remember property test. Refs #3219

Changeset: f860104a73c44e2a684c873fa2d05238a76ff5a4

comment:23 Changed 7 years ago by Andrei Savici

Forget property value. Refs #3219

Changeset: c4be6ab8d5d76cc42f97f1d237aeafa7762bac0d

comment:24 Changed 7 years ago by Andrei Savici

Remember property test. Refs #3219

Changeset: f860104a73c44e2a684c873fa2d05238a76ff5a4

comment:25 Changed 7 years ago by Andrei Savici

Forget property value. Refs #3219

Changeset: c4be6ab8d5d76cc42f97f1d237aeafa7762bac0d

comment:26 Changed 7 years ago by Andrei Savici

Remember property test. Refs #3219

Changeset: f860104a73c44e2a684c873fa2d05238a76ff5a4

comment:27 Changed 7 years ago by Andrei Savici

Forget property value. Refs #3219

Changeset: c4be6ab8d5d76cc42f97f1d237aeafa7762bac0d

comment:28 Changed 7 years ago by Andrei Savici

Remember property test. Refs #3219

Changeset: f860104a73c44e2a684c873fa2d05238a76ff5a4

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4066

Note: See TracTickets for help on using tickets.