Ticket #3315 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Non-Axis aligned cuts for MD event Workspaces

Reported by: Nick Draper Owned by: Owen Arnold
Priority: critical Milestone: Iteration 30
Component: VATES Keywords:
Cc: Blocked By: #3638
Blocking: Tester: Peter Parker

Description

Work with Janik and Alex to perform non axis aligned cuts on MDEvent workspaces

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Component changed from Mantid to VATES

comment:2 Changed 9 years ago by Owen Arnold

In [13078]:

re #3315. Janik has already got a good deal of code in place to do this. Additional tests here to verify that a well-formed rotation matrix is handled by CoordTransform object.

comment:3 Changed 9 years ago by Owen Arnold

In [13083]:

re #3315. Calculate additional vector information to describe a plane. PlaneImplicitFunction not yet setup to handle this yet.

comment:4 Changed 9 years ago by Janik Zikovsky

In [13090]:

Refs #3315: Started MDGridBox general binning method.

comment:5 Changed 9 years ago by Janik Zikovsky

In [13091]:

Refs #3315: More methods for non-axis-aligned bins. Needs tests.

comment:6 Changed 9 years ago by Owen Arnold

In [13110]:

re #3315. Fix Origin & Normal parameter tests.

comment:7 Changed 9 years ago by Owen Arnold

In [13111]:

re #3315. Fix. No need for scope resolution. VC++ doesn't complain about this obvious error.

comment:8 Changed 9 years ago by Owen Arnold

In [13112]:

re #3315. Get rid of GCC Warning.

comment:9 Changed 9 years ago by Owen Arnold

In [13113]:

re #3315. Get rid of GCC Warning.

comment:10 Changed 9 years ago by Owen Arnold

In [13211]:

Refs #3364, #3315. Disable feature. Address as part of pending 3315

comment:11 Changed 9 years ago by Owen Arnold

In [13308]:

Refs #3315. Updated schema to handle coordinate transformations.

comment:12 Changed 9 years ago by Owen Arnold

In [13312]:

Refs #3315. Affine Matrix Parameter introduced so that xml serialization/de-serialization will be easier than dealing with bulk type.

comment:13 Changed 9 years ago by Owen Arnold

In [13337]:

Refs #3315. Parser for AffineMatrixParameter.

comment:14 Changed 9 years ago by Owen Arnold

In [13338]:

Refs #3315. Since Parameters are useful concepts, it's worth the effort to make their use as generic as possible. VectorParameter is put into use here. Next steps include Renaming theis VectorParameter3D, so that a true VectorParameter can be pushed up into API along with SingleValueParameter. Those can then be used across projects.

comment:15 Changed 9 years ago by Owen Arnold

In [13339]:

Refs #3315. Fix tests.

comment:16 Changed 9 years ago by Owen Arnold

In [13340]:

Refs #3315. Fix GCC issue.

comment:17 Changed 9 years ago by Owen Arnold

In [13341]:

Refs #3315. Removed unused cpp files.

comment:18 Changed 9 years ago by Owen Arnold

In [13343]:

Refs #3315. Rename VectorParameter to Vector3DParameter.h. Same with parser.

comment:19 Changed 9 years ago by Owen Arnold

In [13344]:

Refs #3315. Rename Vector types to Vector3D ...

comment:20 Changed 9 years ago by Owen Arnold

In [13347]:

Refs #3315. SingleValueParameter.h created in API. MDAlgorithm SingleValueParameters now use this. Other minor warnings cleared up.

comment:21 Changed 9 years ago by Owen Arnold

In [13348]:

Refs #3315. Fix warnings.

comment:22 Changed 9 years ago by Owen Arnold

In [13349]:

Refs #3315. Move typedefs specific to MDAlgorithms out of the SingleValueParameterParser so that it can be moved as part of next step into API.

comment:23 Changed 9 years ago by Owen Arnold

In [13350]:

Refs #3315. Fix. Remove cpp file crom CMakeLists.txt

comment:24 Changed 9 years ago by Owen Arnold

In [13351]:

Refs #3315. Moved SingleValueParameterParser to API.

comment:25 Changed 9 years ago by Owen Arnold

In [13353]:

Refs #3315. Clean-up namespaces and headers.

comment:26 Changed 9 years ago by Owen Arnold

In [13357]:

Refs #3315. VectorParameter and VectorParameterParser in API

comment:27 Changed 9 years ago by Owen Arnold

In [13359]:

Refs #3315. Fix GCC Error.

comment:28 Changed 9 years ago by Owen Arnold

In [13360]:

Refs #3315. Fix GCC Error.

comment:29 Changed 9 years ago by Janik Zikovsky

In [13361]:

Refs #3315: Fix GCC test build

comment:30 Changed 9 years ago by Owen Arnold

In [13362]:

Refs #3315. Disable test until local fix.

comment:31 Changed 9 years ago by Mathieu Doucet

In [13396]:

Fix warning. Re #3315

comment:32 Changed 9 years ago by Owen Arnold

In [13405]:

Refs #3315. Achieve type independence for templated VectorParameters and parsers.

comment:33 Changed 9 years ago by Owen Arnold

In [13407]:

Refs #3315. Coordinate transform types now using Parameter types. Also serialization introduced and tested. Due to annoying boolean storage in vectors, workings of VectorParameter now use raw array rather than vectors.

comment:34 Changed 9 years ago by Owen Arnold

In [13408]:

Refs #3315. Purge gcc warnings

comment:35 Changed 9 years ago by Martyn Gigg

In [13410]:

Fix for the intel compiler on the Mac and its strange behaviour with assignment operators. Refs #3315

comment:36 Changed 9 years ago by Owen Arnold

In [13413]:

Refs #3315. Fix to VC++ after intel compiler fixed. Complains that no assignment operation is present. So store members on heap instead to prevent potential assignments.

comment:37 Changed 9 years ago by Owen Arnold

In [13424]:

Refs #3315. XML schema updated for coordinate transforms. Important property now available is that Coordinate transforms have a list of parameters. This allows us to support multiple types of CoordTransforms with the same basic schema.

comment:38 Changed 9 years ago by Owen Arnold

In [13465]:

Refs #3315. Reversible serialisation de-serialization. For coordinate transform.

comment:39 Changed 9 years ago by Owen Arnold

In [13466]:

Refs #3315. Kill warnings and correct serialisation for CoordTransformDistance.

comment:40 Changed 9 years ago by Owen Arnold

In [13467]:

Refs #3315. Fix GCC error resulting from Typedef.

comment:41 Changed 9 years ago by Owen Arnold

In [13468]:

Refs #3315. Fix last GCC warning.

comment:42 Changed 9 years ago by Owen Arnold

In [13477]:

Refs #3315. Separate parser for Distance type Coordinate transforms.

comment:43 Changed 9 years ago by Janik Zikovsky

  • Blocked By 3638 added

comment:44 Changed 9 years ago by Janik Zikovsky

In [14628]:

Refs #3638, #3315: Made sure the 'UseTransform' param was transmitted to the factories. Added code to generate the reverse transformation (only for non-axis-cuts, it is likely unnecessary). Not sure about the 2D integrated transform ...

comment:45 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:46 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

see #3683.

comment:47 Changed 9 years ago by Janik Zikovsky

In [14711]:

Refs #3315: Added an option to ForceOrthogonal to paraview plugin.

comment:48 Changed 9 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:49 Changed 9 years ago by Peter Parker

  • Status changed from verifying to closed

[In Win7...]

Used the Mantid Rebinning Transform filter within Paraview and it seems to work as expected after changing the position/orientation of the transform, as well as the "Force Orthogonal" option.

Unit tests passed.

comment:50 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4162

Note: See TracTickets for help on using tickets.