Ticket #3638 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

BinToMDHistoWorkspace: non-axis aligned binning

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: owen.arnold@… Blocked By:
Blocking: #3315 Tester: Owen Arnold

Description

Apply a CoordTransform before binning, as an option.

Support the IterateEvents method only at first, since it will be simpler and tends to be faster.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Owner set to Janik Zikovsky
  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

In [14269]:

Refs #3638: Added a stub for CoordTransformAligned. Reverted CoordTransform to use the bare data types instead of the wrapped parameter types, resulting in a 30% speed up.

comment:3 Changed 9 years ago by Janik Zikovsky

In [14270]:

Refs #3638: Added a class CoordTransformAffine so as to make CoordTransform base class a bare abstract class.

comment:4 Changed 9 years ago by Janik Zikovsky

In [14272]:

Refs #3638: Filled in CoordTransformAligned; it runs 2.5-3x faster than the more general affine transform.

comment:5 Changed 9 years ago by Janik Zikovsky

In [14274]:

Refs #3638: Generalized BintoMDHistoWorkspace further.

comment:6 Changed 9 years ago by Janik Zikovsky

In [14275]:

Refs #3638

comment:7 Changed 9 years ago by Janik Zikovsky

In [14309]:

Refs #3638: Non-axis aligned binning works (in tests at least)

comment:8 Changed 9 years ago by Janik Zikovsky

In [14310]:

Refs #3638: Missed a couple of property name changes

comment:9 Changed 9 years ago by Janik Zikovsky

In [14390]:

Refs #3638: Changed BinToMDHisto to use basis vectors for the non-aligned cuts. Added utility string methods to VMD. Saving basis vectors in MDHistoDimensions.

comment:10 Changed 9 years ago by Janik Zikovsky

In [14441]:

Refs #3672, #3638: Extra tests to check that the coordinate transform info is properly saved.

comment:11 Changed 9 years ago by Janik Zikovsky

In [14628]:

Refs #3638, #3315: Made sure the 'UseTransform' param was transmitted to the factories. Added code to generate the reverse transformation (only for non-axis-cuts, it is likely unnecessary). Not sure about the 2D integrated transform ...

comment:12 Changed 9 years ago by Janik Zikovsky

In [14672]:

Refs #3638: Fix error in Quat. Method in V3D and VMD to form orthogonal coordinate system out of 2 input vectors.

comment:13 Changed 9 years ago by Janik Zikovsky

In [14673]:

Refs #3638: Option in BinToMDHistoWorkspace to force orthogonal basis vectors

comment:14 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14676]:

Fixes #3638: BinToMD is working well for this iteration. Disabled the non-IterateEVents method if not axis aligned, since it doesn't work. May remove the non-iterate method in the future.

comment:15 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:16 Changed 9 years ago by Owen Arnold

This works. Axis-aligned binning also supported by this algorithm. Used in Vates GUI.

comment:17 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4485

Note: See TracTickets for help on using tickets.