Ticket #3328 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

CMake minimum version update

Reported by: Owen Arnold Owned by: Martyn Gigg
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: taylorrj@… Blocked By:
Blocking: Tester: Stuart Campbell

Description

CMake minimum version is currently set to 2.6, but we have features in the CMake scripts now that require later versions of CMake 2.8.4+ to work properly.

@Martyn, Reassign ticket if needed.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

  • Cc taylorrj@… added

comment:2 Changed 9 years ago by Martyn Gigg

It's only actually Windows which requires CMake-2.8.4 or above due to the bug fix for finding zlib when the library is called zlib1 not just zlib. The library changed name with the version of HDF that was included.

Therefore I think the minimum version should only be moved to 2.8.4 on Windows as it is relatively pain free to get newer version on those platforms.

comment:3 Changed 9 years ago by Russell Taylor

Yes, we shouldn't set the minimum version unnecessarily high on platforms where the build works with lower versions. RHEL5 comes with 2.6, RHEL6 with 2.8.1 and although it's not hard to install a new version we shouldn't require it.

Changing the minimum version on windows is probably the best solution. Other solutions are: import the repaired FindZLib into our Build/CMake directory (though I prefer to avoid this where possible) or include a copy of zlib1 in Third_Party renamed to zlib (this is the hack I previously employed - I see those copies have gone now).

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:7 Changed 9 years ago by Martyn Gigg

Refs #3328. Update minium CMake version.

Now that we don't support RHEL5 move to 2.8

Changeset: cb122078d471e4bd041408bfe8693e3120600526

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:10 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4175

Note: See TracTickets for help on using tickets.