Ticket #3376 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ImplicitFunction: expand for MD needs, integrate with MDEventWorkspace

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #3369, #3408 Tester: Owen Arnold

Description

I need a robust way to determine whether a MDBox has any intersection with an ImplicitFunction; I can focus on Box and Plane functions at first.

Simply checking whether the center and/or any of the corners are in the function is insufficient because the box might be LARGER than the width of the plane and so not actually have any of its corners in it.

Calculating the intersection between the edges of the MDBox and the Plane might do it.

Support for non-aligned planes/boxes would be good; maybe do this from the start so there's less to support.

NOTE to myself: A box and a plane with width = pretty much the same thing.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Janik Zikovsky

In [13231]:

Refs #3376: Start of a MDImplicitFunction

comment:3 Changed 9 years ago by Janik Zikovsky

In [13236]:

Refs #3376: Some simple test cases

comment:4 Changed 9 years ago by Janik Zikovsky

In [13238]:

Refs #3376: Intersection of a line and a plane

comment:5 Changed 9 years ago by Janik Zikovsky

In [13241]:

Refs #3376: MDPlane performance tests.

comment:6 Changed 9 years ago by Janik Zikovsky

In [13242]:

Refs #3376: Rule-of-three for MDPlane

comment:7 Changed 9 years ago by Janik Zikovsky

In [13243]:

Refs #3376: MDImplicitFunction

comment:8 Changed 9 years ago by Janik Zikovsky

In [13258]:

Refs #3376: MDPlane constructor using normal and point.

comment:9 Changed 9 years ago by Janik Zikovsky

In [13259]:

Refs #3376: Multiple planes in implicit functions

comment:10 Changed 9 years ago by Janik Zikovsky

In [13260]:

Refs #3376: More tests.

comment:11 Changed 9 years ago by Janik Zikovsky

In [13358]:

Refs #3376: Test to see if an arbitrary shape touches an arbitrary implicit function. Vector version of isPointBounded() with performance test.

comment:12 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [13363]:

Fixes #3376: Vector version of MDImplicitFunction

comment:13 Changed 9 years ago by Janik Zikovsky

  • Blocking 3408 added

comment:3 Changed 9 years ago by Janik Zikovsky

In [13373]:

Refs #3376, Fixes #3409: Method on IMDBox to make the vertexes array. Used that in MDImplicitFunction to determine if a IMDBox touches it. Performance tests for the MDBoxImplicitFunction.

comment:4 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Good test coverage. Wrapped now by PlaneImplicitFunction and BoxImplicitFunction, and existing test suite reused there to verify proper workings.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4223

Note: See TracTickets for help on using tickets.