Ticket #3535 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

ImplicitFunctions: make them subclass MDImplicitFunction

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

... to use that underlying code. This means that the PlaneImplicitFunction, BoxImplicitFunction etc. will be built of these MDPlanes.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

Owen Arnold: No I suggest you essentially copy the BoxImplicitFunction PlaneImplicitFunction give them slightly different names say MDBoxImplicitFunction and MDPlaneImplicitFunction. I'll retire the old code and do any renaming once Nick gives me the all-clear.

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

In [13853]:

Refs #3535: Plane3DImplicitFunction added that uses MDImplictFunction under the hood.

comment:4 Changed 9 years ago by Janik Zikovsky

In [13855]:

Refs #3535: Fix to MDPlane to let performance test pass.

comment:5 Changed 9 years ago by Janik Zikovsky

In [13862]:

Refs #3535: Fix openSuse build.

comment:6 Changed 9 years ago by Janik Zikovsky

In [13863]:

Refs #3535: Fix openSuse build. Also adding a util to delete a class.

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [13933]:

Fixes #3535: Box3DImplicitFunction defined to replace BoxImplicitFunction.

comment:8 Changed 9 years ago by Owen Arnold

Looks really good thus far. Should be really easy now to point the existing builders (i.e. PlaneFunctionBuilder) to create the newer MDImplicitFunction types rather than the older ImplicitFunction types. Other than renaming Box3DImplicitFunction to BoxImplicitFunction, nothing would need to be done to get the existing parsers (i.e. BoxImplicitFunctionParser) to work with the new types. Once that is achieved, the API factory ImplicitFunctionFactory could fully handle the creation of any registered MDImplicitFunction from its xml representation.

comment:9 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:10 Changed 9 years ago by Owen Arnold

Done

comment:11 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4382

Note: See TracTickets for help on using tickets.