Ticket #3535 (closed: fixed)
ImplicitFunctions: make them subclass MDImplicitFunction
| Reported by: | Janik Zikovsky | Owned by: | Janik Zikovsky |
|---|---|---|---|
| Priority: | major | Milestone: | Iteration 30 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
... to use that underlying code. This means that the PlaneImplicitFunction, BoxImplicitFunction etc. will be built of these MDPlanes.
Change History
comment:7 Changed 9 years ago by Janik Zikovsky
- Status changed from accepted to verify
- Resolution set to fixed
In [13933]:
comment:8 Changed 9 years ago by Owen Arnold
Looks really good thus far. Should be really easy now to point the existing builders (i.e. PlaneFunctionBuilder) to create the newer MDImplicitFunction types rather than the older ImplicitFunction types. Other than renaming Box3DImplicitFunction to BoxImplicitFunction, nothing would need to be done to get the existing parsers (i.e. BoxImplicitFunctionParser) to work with the new types. Once that is achieved, the API factory ImplicitFunctionFactory could fully handle the creation of any registered MDImplicitFunction from its xml representation.
comment:9 Changed 9 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:10 Changed 9 years ago by Owen Arnold
Done
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4382
Owen Arnold: No I suggest you essentially copy the BoxImplicitFunction PlaneImplicitFunction give them slightly different names say MDBoxImplicitFunction and MDPlaneImplicitFunction. I'll retire the old code and do any renaming once Nick gives me the all-clear.