Ticket #3599 (closed: fixed)
Add instrument geometry to powder data workspace
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.0 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Vickie Lynch |
Description
Add or edit instrument geometry information to a Workspace which holds data measured from TOF powder diffractomer.
Change History
comment:5 Changed 9 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 9 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:7 Changed 9 years ago by Vickie Lynch
EditTOFPowderDiffractomerGeometry is not declared as an algorithm and does not do anything in the source. Was this closed by mistake?
comment:10 Changed 9 years ago by Russell Taylor
In [14840]:
comment:11 Changed 9 years ago by Stuart Campbell
- Status changed from verifying to reopened
- Resolution fixed deleted
As Russell is editing it...
comment:12 Changed 9 years ago by Stuart Campbell
- Status changed from reopened to assigned
- Owner changed from Wenduo Zhou to Russell Taylor
comment:13 Changed 9 years ago by Russell Taylor
- Owner changed from Russell Taylor to Wenduo Zhou
- Milestone changed from Iteration 30 to Iteration 31
I don't think this algorithm is ready to be in a release yet, and my understanding from a brief chat with Wendou is that it doesn't need to be. Talk to me asap if that's not the case.
comment:14 Changed 9 years ago by Wenduo Zhou
Ticket is transferred to ticket #4092.
comment:16 Changed 9 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to duplicate
comment:17 Changed 9 years ago by Wenduo Zhou
Modify EditTOFDiffractomerGeometry. Refs #3599.
Changeset: 18cac3abe38a36f9214619a3b4d745f388c88036
comment:18 Changed 9 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester changed from Russell Taylor to Vickie Lynch
comment:19 Changed 9 years ago by Vickie Lynch
- Status changed from verifying to reopened
- Resolution duplicate deleted
This does change the instrument values to those in the input dialog, but there are some problems:
All DetectorIDs in the instrument are changed.
Show Instrument does not work after this algorithm is called.
The detector pixels are not in banks or groups any more.
comment:20 Changed 9 years ago by Wenduo Zhou
Minor modification for debug output. Refs #3599.
Changeset: 0aa5715a037ffac101d9c5371ffa5f21c6ef4cdd
comment:22 Changed 9 years ago by Wenduo Zhou
- Status changed from accepted to verify
- Resolution set to fixed
comment:23 Changed 9 years ago by Vickie Lynch
- Status changed from verify to verifying
After discussing the use of this algorithm for reduced data with Wenduo, the problems I found are not important for the way it is already being used. The wiki page discusses the limitations sufficiently.
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 4446
In [14146]: