Ticket #3640 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Create SavePAR algorithm

Reported by: Stuart Campbell Owned by: Michael Reuter
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

A SavePAR() algorithm along the lines of the SavePHX() algorithm.

This is a request from Garrett Granroth:

A command to Save a Par file for the current detector geometry is needed.  
This should work after a group detectors command is used to gang detectors.

Attachments

MakePAR.py (2.1 KB) - added by Stuart Campbell 9 years ago.
Python script to generate PAR file from NeXus files.

Change History

comment:1 Changed 9 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Alex Buts

In [14668]:

refs #3640 save par saves ASCII par file but more tests are needed to be sure that it saves exactly what people expect

comment:3 Changed 9 years ago by Alex Buts

In [14674]:

refs #3640 temporary blocking failing on mac test until build is fixed and permanent fix can be verified.

comment:4 Changed 9 years ago by Alex Buts

In [14708]:

refs #3640 this should be all done on this ticket.

comment:5 Changed 9 years ago by Alex Buts

In [14710]:

refs #3640 fixing Unix errors and warnings

comment:6 Changed 9 years ago by Alex Buts

In [14713]:

refs #3640 attempt to deal with Unix error.

comment:7 Changed 9 years ago by Alex Buts

In [14715]:

refs #3640 attempt to deal with Unix error.

comment:8 Changed 9 years ago by Alex Buts

In [14716]:

refs #3640 attempt to deal with Unix error.

comment:9 Changed 9 years ago by Alex Buts

In [14722]:

refs #3640 fixing mac error which should exhaust the opportunities, despite lexical cast can appear better.

comment:10 Changed 9 years ago by Alex Buts

In [14723]:

refs #3640 big simplification -- change to lexical_cast

comment:11 Changed 9 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

should do the job. How these par files are related to par files produced by other algorithms, still should be verified.

comment:12 Changed 9 years ago by Alex Buts

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:13 Changed 9 years ago by Alex Buts

  • Status changed from reopened to assigned

comment:14 Changed 9 years ago by Alex Buts

  • Status changed from assigned to accepted

comment:15 Changed 9 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:17 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The numbers in the PAR file look close enough, I am just alittle concerned that the azimuthal angle has the opposite sign to that produced from our files.

Changed 9 years ago by Stuart Campbell

Python script to generate PAR file from NeXus files.

comment:18 Changed 9 years ago by Stuart Campbell

I have attached the script we use to generate the PAR files for an ungrouped instrument. The script reads a NeXus file (you can use CNCS_7860_event.nxs in the AutoTestData directory)

comment:19 Changed 9 years ago by Stuart Campbell

Created ticket #3798 for missing wiki page.

comment:20 Changed 9 years ago by Stuart Campbell

  • Owner changed from Alex Buts to Michael Reuter
  • Status changed from reopened to assigned

comment:21 Changed 9 years ago by Stuart Campbell

Changed owner to Michael just so we can close it.

comment:22 Changed 9 years ago by Michael Reuter

  • Status changed from assigned to accepted

comment:23 Changed 9 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:24 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying

comment:25 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

Apparently, the sign change for the azimuthal angle is deliberate.

From Toby (via Alex):

/*!
*    an ASCII Tobyfit par file format:
*
*     par(6,ndet)         contents of array
*
*         1st column      sample-detector distance
*         2nd  "          scattering angle (deg)
*         3rd  "          azimuthal angle (deg)
*                     (west bank = 0 deg, north bank = -90 deg etc.)
*                     (Note the reversed sign convention cf .phx files)
*         4th  "          width (m)
*         5th  "          height (m)
*         6th  "          DetID (m)
*-----------------------------------------------------------------------
*/

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4487

Note: See TracTickets for help on using tickets.