Ticket #3641 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Workspace Mementos

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 2.0
Component: VATES Keywords:
Cc: Blocked By: #3876
Blocking: Tester: Nick Draper

Description

Implement architecture created with N. Draper for workspace mementos. These are critical to completing the Single Crystal and Inelastic workflows.

Change History

comment:1 Changed 9 years ago by Owen Arnold

In [14286]:

refs #3641. First pass. It is known that the exact column list for the underlying tableworkspace is not confirmed.

comment:2 Changed 9 years ago by Owen Arnold

In [14287]:

refs #3641. Missed changes to abstract column base class.

comment:3 Changed 9 years ago by Owen Arnold

In [14288]:

refs #3641. Fix GCC issue.

comment:4 Changed 9 years ago by Owen Arnold

In [14289]:

refs #3641. Fix GCC issue.

comment:5 Changed 9 years ago by Owen Arnold

In [14290]:

refs #3641. Fix GCC test issue.

comment:6 Changed 9 years ago by Owen Arnold

In [14292]:

refs #3641. Fix warnings.

comment:7 Changed 9 years ago by Owen Arnold

In [14293]:

refs #3641. Fix warnings.

comment:8 Changed 9 years ago by Owen Arnold

In [14318]:

refs #3641. Fix warnings. RHEL6.

comment:9 Changed 9 years ago by Owen Arnold

In [14321]:

refs #3641. Plan to move MementoCollection types out of DataObjects and therefore need to depend on API ITableWorkspace etc rather than TableWorkspace related types in DataObjects.

comment:10 Changed 9 years ago by Owen Arnold

In [14328]:

refs #3641. As discussed with Nick, MementoTableWorkspace used to pre-define columns for workspace mementos. Also have static code for comparison with ITableWorkspaces, but this should be moved in future.

comment:11 Changed 9 years ago by Owen Arnold

In [14333]:

refs #3641. Move memento items to custom interfaces.

comment:12 Changed 9 years ago by Owen Arnold

In [14334]:

refs #3641. Move memento items to custom interfaces.

comment:13 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:14 Changed 9 years ago by Owen Arnold

  • Blocked By 3876 added

comment:15 Changed 9 years ago by Owen Arnold

In [14961]:

Starter components for GUI. Note this is far from a working version at this stage! Tests for workspace mementos and Qt MVC components introduced. refs #3641 #3876

comment:2 Changed 9 years ago by Owen Arnold

In [14963]:

Fix GCC issues. refs #3641 #3876

comment:3 Changed 9 years ago by Owen Arnold

In [14964]:

Fix GCC issues. refs #3641 #3876

comment:4 Changed 9 years ago by Owen Arnold

In [14973]:

Error in CMake file. refs #3641 #3876

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:6 Changed 9 years ago by Owen Arnold

In [15083]:

Make it easier to check input unit cells and minor fix to xml parser. refs #3641.

comment:7 Changed 9 years ago by Owen Arnold

In [15095]:

Close to a vertical stripe through the functionality. Now include the ability to configure things on a group by group basis and highlight components as unmodified/modified and invalid. Need to boost test coverage yet. refs #3641 #3876.

comment:7 Changed 9 years ago by Owen Arnold

In [15098]:

Fix build errors for GCC. refs #3641 #3876.

comment:8 Changed 9 years ago by Owen Arnold

In [15099]:

More fixes for GCC. refs #3641 #3876.

comment:9 Changed 9 years ago by Owen Arnold

In [15100]:

More fixes for GCC. refs #3641 #3876.

comment:10 Changed 9 years ago by Owen Arnold

In [15101]:

More fixes for GCC. refs #3641 #3876.

comment:11 Changed 9 years ago by Owen Arnold

In [15119]:

Test Lattice Presenter. refs #3641 #3876.

comment:12 Changed 9 years ago by Owen Arnold

In [15120]:

Test SingleOwnerLock. refs #3641

comment:13 Changed 9 years ago by Owen Arnold

In [15123]:

Test and cleanup LoanedMemento. refs #3641

comment:14 Changed 9 years ago by Owen Arnold

In [15124]:

Fix warnings. refs #3641

comment:15 Changed 9 years ago by Owen Arnold

In [15237]:

Ability to configure an approach at start-up. Also generate a single service for any kind of mappings involving table workspaces. Makes code more explicit and easier to handle future modifications. refs #3641 #3876.

comment:13 Changed 9 years ago by Owen Arnold

In [15239]:

GCC Fix. refs #3641

comment:14 Changed 9 years ago by Owen Arnold

In [15240]:

Kill warning. refs #3641

comment:15 Changed 9 years ago by Owen Arnold

In [15241]:

Kill warning. refs #3641

comment:16 Changed 9 years ago by Owen Arnold

In [15285]:

Get ready to handle log values. refs #3641

comment:17 Changed 9 years ago by Owen Arnold

In [15286]:

Fix errors and warnings refs #3641

comment:18 Changed 9 years ago by Owen Arnold

In [15287]:

Fix errors and warnings refs #3641

comment:19 Changed 9 years ago by Owen Arnold

In [15345]:

Reading log values. refs #3641 #3876.

comment:14 Changed 9 years ago by Owen Arnold

In [15346]:

Unused args warning fix. refs #3641 #3876.

comment:39 Changed 9 years ago by Owen Arnold

refs #3641 Presenter can add and edit log values

Changeset: 06bc15154c321cad76de0e1b6616e1a843f318c0

comment:40 Changed 9 years ago by Owen Arnold

refs #3641 fix cmake error

Changeset: 2dc29d98d98e3f3a8269f0e867ad8797633f0bd0

comment:41 Changed 9 years ago by Owen Arnold

Correct warnings refs #3641

Changeset: 9761a96ef8a024832a388ffb3ab504a1143e3896

comment:42 Changed 9 years ago by Owen Arnold

Boost test coverage refs #3641

Changeset: 926bf82e36b4c90c95efc3f1151725696273de5a

comment:43 Changed 9 years ago by Owen Arnold

refs #3641 #3876. Better display of log values. Carry names in memento items for logs. Better type safety. Moving towards being able to handle multiple registered workspaces

Changeset: 8eb7771ab886998d13c284e421da19f721319877

comment:44 Changed 9 years ago by Owen Arnold

refs #3641 #3876. Fix warnings

Changeset: d8c3d3d7e7a5e6ef0a1034eebca10b6cb565148f

comment:45 Changed 9 years ago by Owen Arnold

refs #3641. Fix enum usage.

Changeset: d4bd24c79b7e02fd1586d8c751c0aa6ba8346ba6

comment:46 Changed 9 years ago by Owen Arnold

refs #3641 fix GCC issue.

Changeset: 2b3860128eb32ede70e83ba44a9cc9a213874e86

comment:47 Changed 9 years ago by Owen Arnold

refs #3641 Editing Logs

Working on being able to edit log values and rollback changes. Also fixed a bad pointer problem. Changeset: 3ca8c049dab44b5fa5edeb7529c19c0dcf5c5865

comment:48 Changed 9 years ago by Owen Arnold

refs #3641. Fix enum usage.

Changeset: d4bd24c79b7e02fd1586d8c751c0aa6ba8346ba6

comment:49 Changed 9 years ago by Owen Arnold

refs #3641 fix GCC issue.

Changeset: 2b3860128eb32ede70e83ba44a9cc9a213874e86

comment:50 Changed 9 years ago by Owen Arnold

refs #4328, #3641 Work on mementos.

Can now store lattice information, so more transaction like. Improvements internal python algorithms used for UB generation. Changeset: 6166abab73f37e983a3a595dc81a3644a293cf94

comment:51 Changed 9 years ago by Owen Arnold

refs #4328 #3641. Add apply action functionality.

Also restrict use of setGoniometer for timebeing until a good mechanism for storing/resetting the goniometer can be found. Changeset: fd31765bb7c345b3a68a114de981e2b66052e35a

comment:52 Changed 9 years ago by Owen Arnold

refs #4328 #3641. Make WorkspaceMemento ADT workspace type intependent

Changeset: 935605e7e5f6e22df1626d8a274bfd6f374a2d23

comment:53 Changed 9 years ago by Owen Arnold

refs #4328 #3641. Add missing includes

Changeset: dbdae8ddc76c629cac5eeeb1f3e04add4f834438

comment:54 Changed 9 years ago by Owen Arnold

refs #3641. Prepare for additional memento types

Changeset: a722e89a7f14484b70e6e65e851217df919041ff

comment:55 Changed 9 years ago by Owen Arnold

refs #3641. Rename existing types

Changeset: 162fd669e249d1b3afa7ae03eae42997fef1e885

comment:56 Changed 9 years ago by Owen Arnold

refs #4328 #3641. Add EventNexus memento. Improve Gui Layout.

Event Nexus Files can now be added. Gui Layout improved. Start work on Workspace creation methods. Changeset: cf38125c7e1a2deb38e17889197ad2a1e808f1f5

comment:57 Changed 9 years ago by Owen Arnold

refs #4328 #3641. Add custom dialog and fix bug.

Custom dialog enables users to enter parameters for ConvertToMDEvents once. Changeset: 9708cb237d6a959af46686bc77c4fd5bb415073f

comment:58 Changed 9 years ago by Owen Arnold

refs #3641. Improve speed by loading minimal data.

Changeset: 12405b057b13c806bdf2a48ca25cc267a5384634

comment:59 Changed 9 years ago by Owen Arnold

refs #3641. Improve speed by loading minimal on event data.

Changeset: 977cb2ebd77ba8a0fa1b6fb58e478d5dd0e67e45

comment:60 Changed 9 years ago by Owen Arnold

refs #4328 #3641. First version working end to end.

Overall algorithm dialog. Can convert workspaces and save them to disk. Merging next. Changeset: 4abbbfbb4b3e87e38f29e8aa4b995b5f2138aac8

comment:61 Changed 9 years ago by Owen Arnold

refs #4328 #3641. Improve merge process.

Changeset: 21eb202e9c853eb8399f6fb91af45c87d569d49d

comment:62 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Support code finished.

Tester: This ticket was to create mementos/proxies to real workspaces either on disk or in the ADS. This feature is required to support the GUI work and therefore not easily testable in it's own right. However, there are a set of Unit tests as part of the CustomInterfaces, which exercise this functionality. I suggest that the tester ensures that these run properly and provide adequate coverage as part of the test process.

comment:63 Changed 9 years ago by Nick Draper

don't mix them with diet coke!

Oh no that's mentos

comment:64 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:65 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

unit tests verified on build server

comment:66 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4488

Note: See TracTickets for help on using tickets.