Ticket #4328 (closed: fixed)
Simple CreateMDWorkspace GUI
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Release 2.0 |
Component: | VATES | Keywords: | |
Cc: | Blocked By: | #4201, #4536, #4537 | |
Blocking: | Tester: | Andrei Savici |
Attachments
Change History
comment:2 Changed 9 years ago by Owen Arnold
refs #4328. Resolve merge conflict.
Changeset: 25fe889bcd7352e39053fa20a7b32148ba5377e7
comment:3 Changed 9 years ago by Owen Arnold
refs #4328. Standard compliant ifstream usage.
Changeset: d78451e4b023bf4d8caaf1f6f1de93f5eb71d98c
comment:4 Changed 9 years ago by Owen Arnold
refs #4328. Standard compliant ifstream usage.
Changeset: f0797f1db0fb6a61fd30e4a94ff166e419bd8fae
comment:5 Changed 9 years ago by Owen Arnold
refs #4328. Addition and Removal features.
Can add a workspace and remove it from the memento collection. Rules applied to prevent duplicates. Most of the implementation is generic.
Changeset: 23142365d9a6e7ebec3e86626bf5cd6f458f1387
comment:6 Changed 9 years ago by Owen Arnold
refs #4328. Remove old comparitor.
Changeset: 52f51c0f31c92e798394576632e53b80719459e8
comment:7 Changed 9 years ago by Owen Arnold
refs #4328. Fix const issue.
Changeset: 057e135077d7eea2ae0b61fe64089635daf1dafe
comment:8 Changed 9 years ago by Owen Arnold
refs #4328. Fix conversion error.
Changeset: 751214279c5bd67614ceb36c1b74452d6825c29a
comment:9 Changed 9 years ago by Owen Arnold
refs #4328 Functionality for setting the UB Matrix
Changeset: d30a86156b714f0f54c59c89fc5bb1da344c065c
comment:10 Changed 9 years ago by Owen Arnold
refs #4328 Change id for OnDisk Mementos.
Changeset: 7a29ed208b2995c870b8639219f147da9c93bbed
comment:11 Changed 9 years ago by Owen Arnold
refs #4328 Work on Raw file processing with OrientedLattices.
Changeset: 956f6a62c9cdd81a93f9be9bf4a32727efa9aecf
comment:12 Changed 9 years ago by Owen Arnold
refs #4328, #3641 Work on mementos.
Can now store lattice information, so more transaction like. Improvements internal python algorithms used for UB generation. Changeset: 6166abab73f37e983a3a595dc81a3644a293cf94
comment:13 Changed 9 years ago by Owen Arnold
refs #4328. Better handling of errors in python.
Changeset: 158f3f6a132ecafcb1f19ebecd775413f4be4974
comment:14 Changed 9 years ago by Owen Arnold
refs #4328. Start handling goniometer settings.
Changeset: 444b746683c62f531097458b84fcb2c8e2bd4b55
comment:15 Changed 9 years ago by Owen Arnold
refs #4328. Fix nested enum usage warnings.
Changeset: 9854b07b94eea4f72bdce985cf782fad16a71e97
comment:16 Changed 9 years ago by Owen Arnold
refs #4328. Fix GCC warnings. Remove additional const.
Changeset: bd450bf5e23d4a1c41b3745a63d288f0dc17a227
comment:17 Changed 9 years ago by Owen Arnold
refs #4328. Apply default arguments
Changeset: 04a6382449e4f2e790a9098eeba3ea639bf4ba1e
comment:18 Changed 9 years ago by Owen Arnold
refs #4328. Unit test new features in PythonAPI
Changeset: f4d6e1925b09a47419208b5bc8b33d8d795ec0a7
comment:19 Changed 9 years ago by Owen Arnold
Last two commits belong to #4387
comment:20 Changed 9 years ago by Owen Arnold
refs #4328 #3641. Add apply action functionality.
Also restrict use of setGoniometer for timebeing until a good mechanism for storing/resetting the goniometer can be found. Changeset: fd31765bb7c345b3a68a114de981e2b66052e35a
comment:21 Changed 9 years ago by Owen Arnold
refs #4328. Fix errors around accessing workspaces
Changeset: 937d359b93db66fde5b933995926cd26a70ce33d
comment:22 Changed 9 years ago by Owen Arnold
refs #4328 #3641. Make WorkspaceMemento ADT workspace type intependent
Changeset: 935605e7e5f6e22df1626d8a274bfd6f374a2d23
comment:23 Changed 9 years ago by Owen Arnold
refs #4328 #3641. Add missing includes
Changeset: dbdae8ddc76c629cac5eeeb1f3e04add4f834438
comment:24 Changed 9 years ago by Owen Arnold
refs #4328 #3641. Add EventNexus memento. Improve Gui Layout.
Event Nexus Files can now be added. Gui Layout improved. Start work on Workspace creation methods. Changeset: cf38125c7e1a2deb38e17889197ad2a1e808f1f5
comment:25 Changed 9 years ago by Owen Arnold
refs #4328. Fix type conversion warning.
Changeset: d76c05cf48201d92be3a9170bfac934ddddaf75e
comment:26 Changed 9 years ago by Owen Arnold
refs #4328 #3641. Add custom dialog and fix bug.
Custom dialog enables users to enter parameters for ConvertToMDEvents once. Changeset: 9708cb237d6a959af46686bc77c4fd5bb415073f
comment:27 Changed 9 years ago by Owen Arnold
refs #4328 #3641. First version working end to end.
Overall algorithm dialog. Can convert workspaces and save them to disk. Merging next. Changeset: 4abbbfbb4b3e87e38f29e8aa4b995b5f2138aac8
comment:28 Changed 9 years ago by Owen Arnold
refs #4328 #3641. Improve merge process.
Changeset: 21eb202e9c853eb8399f6fb91af45c87d569d49d
comment:29 Changed 9 years ago by Owen Arnold
refs #4328. Add missing argument to algorith call.
Changeset: 0837d039adc9cb80bc1a7e7229ad332079e63bed
comment:31 Changed 9 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester:
Please contact me for guidance on how to test this item. I can provide a script to generate some input workspaces to run the GUI on.
comment:32 Changed 9 years ago by Owen Arnold
Tester:
Here is a Test scenario:
- Step (1): Create an empty output directory somewhere
- In mantid plot launch Interfaces->Create MD Workspace
- In mantid plot open the python interpreter and run cncs.py
- Using the 'Add Workspace' button add all the workspaces generated by the script
- Click on 'Create Workspace' and set the output directory to (1).
- A dialog should appear. Select QxQyQz, Direct and min to -2,-2,-3,-1 and max to 2,2,3,3
- Click Ok on the dialog
- Check the output directory (1) which should now contain workspaces ending with *_md.nxs
(Repeat above selecting 'Merge all Md Workspaces') which should produce an additional merged workspace.
comment:33 Changed 9 years ago by Owen Arnold
Tester:
Here is another Test scenario:
- Step (1): Create an empty output directory somewhere
- In mantid plot launch Interfaces->Create MD Workspace
- In mantid plot open the python interpreter and run mari.py (attached)
- Using the 'Add Workspace' button add all the workspaces generated by the script
- Click on 'Create Workspace' and set the output directory to (1).
- A dialog should appear. Select QxQyQz, Direct and min to -1,-1,-1,-1 and max to 1,1,1,1
- Click Ok on the dialog
- Check the output directory (1) which should now contain workspaces ending with *_md.nxs
(Repeat above selecting 'Merge all Md Workspaces') which should produce an additional merged workspace.
comment:34 Changed 9 years ago by Owen Arnold
refs #4328. Fix bug when changing workspace with no selection.
Changeset: ca2f53c991d7967beb0a098ed6d79c325d8de158
comment:35 Changed 9 years ago by Owen Arnold
- Blocked By 4201 added
Tester: If you are testing this, you must have tested and closed #4201 first
comment:36 Changed 9 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:37 Changed 9 years ago by Owen Arnold
Wiki page set up to contain information about this feature:
comment:38 Changed 9 years ago by Nick Draper
This keeps failing on my pc Windows 7 64 bit with the MARI test. Nothing gets added to the logs.
Checked with new and old python API - no difference.
comment:39 Changed 9 years ago by Owen Arnold
refs #4328. Load existing ADS workspaces.
Changeset: 208dece08b5c9120c48c6935bbd10a6c08a24173
comment:40 Changed 9 years ago by Owen Arnold
refs #4328. Fix. Alg properties changed and hence this code broke.
Changeset: e324334f24eccb11970bec264d1bfc4e00946f01
comment:41 Changed 9 years ago by Owen Arnold
refs #4328. Unit test Properties.
Also fix file path errors and ensure that python errors make it back up to the logs. Changeset: 7363bf660dcd2fe8113e78c7161225cc47e70590
comment:42 Changed 9 years ago by Andrei Savici
Big problems when loading event nexus files:
- You cannot set Goniometer. If you can set UB, why can't you set Goniometer?
- If Ei is not set in the file, the script fails. There is no way to input a fixed energy
VERY, VERY irritating: the gui does not remember settings. Especially for set output location. By default, you should allow to create MD workspaces in memory
Also, we should do something about min/max values
comment:43 Changed 9 years ago by Owen Arnold
Thanks for giving this a run through Andrei.
- That problem only affects workspaces that you 'proxy-load' using 'load nexus' or 'load event nexus' I'll fix it so that you can set the goniometer from proxy files, but if you already have workspaces loaded into MantidPlot, you can change these values. The reason that this is not currently allowed is because it requires storing the goniometer settings on a non-workspace object, but I can fix that.
- Yes, I'll look into if it would be posible to add a log value for energy. via the GUI.
Do you mean the the created workspaces should be kept in memory rather than written out to disk? How would you like this to work?
What do you suggest doing about min/max values?
comment:44 Changed 9 years ago by Owen Arnold
refs #4328. Fixes usage issues raised for event workspaces.
Can always set goniometer. Can always set log values. Can also now keep workspaces in memory.
Changeset: f83c69840517f3665c91616bf675ce4f6a5e8d9a
comment:45 Changed 9 years ago by Owen Arnold
refs #4328 Fix GCC warnings
Changeset: 3466a49f9e4a35cfb1369af2b4328599e102ce08
comment:46 Changed 9 years ago by Owen Arnold
refs #4328 Default directory preference.
Changeset: 15003c822d3afdc54e5fcc1f68f8909b8b415286
comment:47 Changed 9 years ago by Owen Arnold
refs #4328 Fix error.
Changeset: 7705390757559d8ce167b99019cdb1b32210441b
comment:48 Changed 9 years ago by Owen Arnold
refs #4328 Working prototype for resource managing smart ptr.
. Guarantees exeption safety, will always call clean on mementos.
Changeset: 02027cea2f9829c88901fac0774acd8cba520169
comment:49 Changed 9 years ago by Owen Arnold
refs #4328. Relocate and mock-test smart ptr.
Changeset: 23c8661a9b7776136f33c26dfdbd63a872961799
comment:50 Changed 9 years ago by Owen Arnold
refs #4328. Relocate and mock-test smart ptr.
Changeset: 6cea8e6a2f5099625a07ef9478acab5f16351a5b
comment:51 Changed 9 years ago by Owen Arnold
refs #4328. Multiselect input files.
Changeset: 2e0f904c091a38b08cb08e43d95f0978cda33cc4
comment:54 Changed 9 years ago by Owen Arnold
refs #4328. Fixes usage issues raised for event workspaces.
Can always set goniometer. Can always set log values. Can also now keep workspaces in memory.
Changeset: f83c69840517f3665c91616bf675ce4f6a5e8d9a
comment:55 Changed 9 years ago by Owen Arnold
refs #4328 Fix GCC warnings
Changeset: 3466a49f9e4a35cfb1369af2b4328599e102ce08
comment:56 Changed 9 years ago by Owen Arnold
refs #4328 Default directory preference.
Changeset: 15003c822d3afdc54e5fcc1f68f8909b8b415286
comment:57 Changed 9 years ago by Owen Arnold
refs #4328 Fix error.
Changeset: 7705390757559d8ce167b99019cdb1b32210441b
comment:58 Changed 9 years ago by Owen Arnold
refs #4328 Working prototype for resource managing smart ptr.
. Guarantees exeption safety, will always call clean on mementos.
Changeset: 02027cea2f9829c88901fac0774acd8cba520169
comment:59 Changed 9 years ago by Owen Arnold
refs #4328. Relocate and mock-test smart ptr.
Changeset: 23c8661a9b7776136f33c26dfdbd63a872961799
comment:60 Changed 9 years ago by Owen Arnold
refs #4328. Relocate and mock-test smart ptr.
Changeset: 6cea8e6a2f5099625a07ef9478acab5f16351a5b
comment:61 Changed 9 years ago by Owen Arnold
refs #4328. Multiselect input files.
Changeset: 2e0f904c091a38b08cb08e43d95f0978cda33cc4
comment:62 Changed 9 years ago by Andrei Savici
Note for the future: help button and wiki
comment:63 Changed 9 years ago by Owen Arnold
Agree with Andrei for the above request. I'll handle this under #4555.
comment:64 Changed 9 years ago by Owen Arnold
refs #4328. Better file checking prior to loading.
Changeset: b5a1dd3fa0c23b3d0348638deb25cf2ae187d8f5
comment:65 Changed 9 years ago by Owen Arnold
refs #4328. Fix merge using Min Max recursion properties
Changeset: 2a258d0f08f1afa7b6414eb2ea5dd648cd0fdd52
comment:67 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 5175