Ticket #4329 (closed: invalid)

Opened 9 years ago

Last modified 5 years ago

What to do when converting LoadMuonNexus to use the new File Nexus Interface

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: minor Milestone: Release 3.2
Component: Framework Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

An investigation #4037 suggests that when we would change LoadMuonLog to use the new Nexus File interface, it would be good instead to get the LoadNexusLogs to do the work of LoadMuonLog and withdraw the latter algorithm.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:2 Changed 9 years ago by Russell Taylor

Noticed that the following commit did not make it into this ticket:

commit ff60c8d4dcb223564888dc895b968abbb4e46cae
Author: Karl Palmen <karl.palmen@stfc.ac.uk>
Date:   Fri Dec 16 10:33:57 2011 +0000

    Changes made towards making LoadNexusLogs.cpp load Muon Nexus Data
    
    This may be useful for re #4329. Saved in branch muon_nexus_in_nexus.

This commit currently exists only on the branch mentioned above, and not in master. It's the only unmerged commit on that branch.

comment:3 Changed 9 years ago by Karl Palmen

The work committed to this branch is not complete.

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to release 2.4

comment:7 Changed 8 years ago by Karl Palmen

  • Milestone changed from Release 2.4 to Release 2.5

comment:8 Changed 7 years ago by Karl Palmen

  • Milestone changed from Release 2.5 to Release 2.6

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:11 Changed 7 years ago by Russell Taylor

The branch mentioned above is the oldest one still sitting on github. I propose to delete it - the small changes are to files that will have moved on a long way since then (and I'm not sure touching LoadTOFRawNexus was the right thing to do anyway). Let me know if you object.

Is this ticket even still relevant?

comment:12 Changed 7 years ago by Karl Palmen

I expect this ticket is obselete, but I want Anders to comment on it.

comment:13 Changed 7 years ago by Anders Markvardsen

Yes please close this ticket and delete this branch. Thanks

comment:14 Changed 7 years ago by Karl Palmen

  • Status changed from new to verify
  • Resolution set to invalid

comment:15 Changed 7 years ago by Karl Palmen

You may test by verifying the banch muon_nexus_in_nexus does not exist.

comment:16 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg
  • Milestone changed from Backlog to Release 3.2

comment:17 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that the commit mentioned is not in master and that the branch is gone.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 5176

Note: See TracTickets for help on using tickets.