Ticket #3659 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Create algorithm for Detailed Balance correction

Reported by: Stuart Campbell Owned by: Andrei Savici
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By: #3699
Blocking: Tester: Wenduo Zhou

Description


Change History

comment:1 Changed 9 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Andrei Savici

In [14572]:

Detailed balance correction algorithm. Updated physical constants to calculate energy to wavevector constant. Updated physical constants with energy to temperature conversion constant. Refs #3659

comment:3 Changed 9 years ago by Andrei Savici

  • Blocked By 3699 added

The algorithm does not work for events, since UnaryOperations and OneMinusExponentialCor are not event aware. Still some tests to write.

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:6 Changed 9 years ago by Nick Draper

This is already done, in python at least,

Look at inelastic_indirect_reduction_steps.py class DetailedBalance

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to duplicate

comment:8 Changed 9 years ago by Stuart Campbell

Are you suggesting that we remove the algorithm that has been committed ?

comment:9 Changed 9 years ago by Andrei Savici

no test yet

comment:10 Changed 9 years ago by Andrei Savici

  • Status changed from verify to reopened
  • Resolution duplicate deleted

comment:11 Changed 9 years ago by Andrei Savici

Unary operations work for events. Some cleaning up to do, comments, wiki, and test.

comment:12 Changed 9 years ago by Andrei Savici

  • Status changed from reopened to accepted

Detailed balance algorithm. Refs #3659

Changeset: 7cbd12acee681019bf6a7ad9a929c38694cb1ff1

comment:13 Changed 9 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 9 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:15 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4506

Note: See TracTickets for help on using tickets.