Ticket #3726 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Alter background colour of monitors in MantidMatrix

Reported by: Martyn Gigg Owned by: Keith Brown
Priority: major Milestone: Release 3.0
Component: GUI Keywords: Student
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Nick Draper) (diff)

Span out from #953.

Alter the background colour in the Mantid Matrix for monitors.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:3 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:4 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:8 Changed 7 years ago by Nick Draper

  • Keywords Student added

Talk to Martyn or Roman about how to colour the Mantid Matrix cells

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:11 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Keith Brown
  • Milestone changed from Backlog to Release 3.0

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Framework to User Interface
  • Description modified (diff)

comment:13 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress

Working on finding how to get the right rows

I've got some code now that will allow me to get the cells with a background role and they print if they're a detector or not, so I'm getting there.

Refs #3726

Changeset: 6efe1cd37d99eedfedbe65fbc196d372b4528fd0

comment:14 Changed 7 years ago by Keith Brown

Monitors are now in a different colour

The rows that are from a monitor are now coloured a light yellow/cream colour

Refs #3726

Changeset: d0cbc01f3959c17a0bedae71d32207c24da96179

comment:15 Changed 7 years ago by Keith Brown

Done a quick Formatting tidy-up

Used Visual Studio's built in function to format the documents better in terms of indents and such.

Refs #3726

Changeset: d0081af71d2efdc65dec87597700323db8acfe6f

Last edited 7 years ago by Keith Brown (previous) (diff)

comment:16 Changed 7 years ago by Keith Brown

Added Doxygen note for my new method

Documented my new method properly for doxygen.

Refs #3726

Changeset: 879097ffabd5393680a3aa1409ceadcc1afede77

comment:17 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester:

Load any file and open the matrix view and look for crean coloured rows. Those rows should correspond to "yes" flags in the 'monitor' field of "show detectors"

Also look at general performance on a very large file, it may be a bit sluggish the first time you start scrolling as it caches the detector flags but should speed up after it's done that.

comment:18 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:19 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

It does not work for me. This may be because I have set my Mantid to display table workspaces in pink. I think it should alter the background colour even if the user has changed it. I suggest a paler or creamier version of the colour, if it is not white.

comment:20 Changed 7 years ago by Karl Palmen

Oops! I looked at show detectors, which gives a table workspace. I think it was show data that was intended and that does work, despite me setting the background colour to cyan. Please set ticket to fixed so I can pass testing, unless you want to extend this to show detectors.

comment:21 Changed 7 years ago by Keith Brown

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:22 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying

comment:23 Changed 7 years ago by Karl Palmen

The lines of Show Data shown in cream did correspond to the monitors shown in Show Detectors.

comment:24 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/3726_Matrix_BG_Color_Change'

Full changeset: ​61863775d22f5879b2821f0096b7af15576f4ea2

comment:25 Changed 7 years ago by Karl Palmen

Another possible ticket is to apply the same to Table Workspace as used in Show Detectors. This is less important, because the table has a column stating whether the detector is a monitor.

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4573

Note: See TracTickets for help on using tickets.