Ticket #3793 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Save ISAW Peaks file failure.

Reported by: Owen Arnold Owned by: Janik Zikovsky
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Saving a peaks workspace in the ISaw *.peaks format is failing.

  • OneStepMDEW /mantid/Test/AutoTestData/CNCS_7860_event.nxs
  • FindPeaksMD (default options for everything)
  • SaveISawPeaks

Cannot load the peaks file see issue #3792 because peaks workspace, which contains 10 peaks is not being saved out correctly.

Change History

comment:1 Changed 9 years ago by Janik Zikovsky

  • Milestone changed from Iteration 30 to Iteration 31

comment:2 Changed 9 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Janik Zikovsky

Real cause is InstrumentRayTracer not quite working on CNCS instrument.

comment:4 Changed 9 years ago by Janik Zikovsky

In [14873]:

Refs #3793: Better ray tracing. Rays originating inside a BoundingBox always intersect. Algorithm for testing out ray tracer.

comment:5 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

In [14875]:

Fixes #3793: CNCS found peaks do save to ISAW peaks file however their 'bank' number is not valid because CNCS does not have rectangular detectors. The detector ID is found correctly from FindPeaksMD but the ISAW format is not well suited for all Mantid instruments. Therefore the output of this process as an ISAW .peaks file is not quite valid, but as far as testers are concerned, it was not meant to be as we will be using a different format in the future.

comment:6 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:7 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

We have a generic way of loading/saving peaks workspaces now in Mantid #4137. Should keep ISAW format as it is to enable users to switch to and from ISAW.

I have tested that the existing ISAW format loading/saving has not been broken as part of these changes.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4640

Note: See TracTickets for help on using tickets.