Ticket #4137 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Need ability to save and load peaks

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

There is a need for peaks to be saved and loaded. There is some peak saving/loading capability with IsawPeaks, but this is only suitable for certain types of instrument. We need a more flexible way of saving peaks. This could be done as a Nexus file.

This ticket addresses issues unresolved in tickets #4104 and #4105 .

Change History

comment:1 Changed 9 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 9 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 9 years ago by Karl Palmen

Peaks created by the FindPeaks algorithm seem to be saved correctly as a table workspace Nexus file. It seems to be peaks created by FindPeaksMD that are not saved as Nexus file. Such peaks have no 'show data' method available in Mantidplot instead one can view the logs.

comment:4 Changed 9 years ago by Karl Palmen

Peaks created by FindPeaks can be saved by either running the SaveNexus algorithm on the peaks workspace, which is a table workspace or by saving the project. The peaks cannot be saved via the right-click menu like with other types of workspace.

comment:5 Changed 9 years ago by Karl Palmen

I've found out that FindPeaksMD saves peaks into a peaks workspace documented at http://www.mantidproject.org/PeaksWorkspace .

The table of peaks can be displayed by double-cliking on this workspace rather than selecting 'show data' in right click menu.

The webpage also says that if you show the instument, one can see where the peaks are in the instrument by dragging the peak workspace into the imstrument picture. I haven't yet been able to do this and may need a better example for this.

comment:6 Changed 9 years ago by Karl Palmen

refs #4137 provided for help with coding

Changeset: 47f0292fcd21d70ac447d36c3af03b35de359e1a

comment:7 Changed 9 years ago by Karl Palmen

The changeset 47f0292fcd21d70ac447d36c3af03b35de359e1a is the creation of a branch save_peaks_nexus to assist me.

comment:8 Changed 9 years ago by Janik Zikovsky

Refs #4137: Start of saving peaks nexus

Changeset: b336bbb4d5cc87fc25f048c763cdc031fa92787e

comment:9 Changed 9 years ago by Karl Palmen

Partially fix new code and put comment for part not yet fixed re #4137

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3a293c44cffe6a45228769c8ffee0178fedaff7d

comment:10 Changed 9 years ago by Karl Palmen

Replaced references to protected members with function calls. Re #4137

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7b9b114ed3e7ab0d29910506e2958881675dbb15

comment:11 Changed 9 years ago by Karl Palmen

Now it saves nine columns into Nexus re #4137

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: fe5eb775709d1410b66538499a2ed8d5ccc305bd

comment:12 Changed 9 years ago by Karl Palmen

Modified declaration of PeaksWorkspace.h declaration of SaveNexus

For re #4137. This is needed to make it acceptable to Jenkins builders.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 566a9d129086fcdf0cb18a132ad17bdd5b9580aa

comment:13 Changed 9 years ago by Karl Palmen

Corrected a declaration in LoadNexus.h file for re #4137

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0c162bf241c97520eedbe42a25681bf7c01ab81f

comment:14 Changed 9 years ago by Karl Palmen

Elimination of compiler warnings re #4137

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d9a322877d0ce16eb7e3272f91bfd93f21814492

comment:15 Changed 9 years ago by Karl Palmen

Unit test for re #4137

PeaksWorkspaceTest.h test_saveNexus

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b2472286b200c37e9e1da128a8c34c3620b84b91

comment:16 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 9 years ago by Karl Palmen

Unit test for re #4137

PeaksWorkspaceTest.h test_saveNexus

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b2472286b200c37e9e1da128a8c34c3620b84b91

comment:18 Changed 9 years ago by Karl Palmen

Completed work on saving/loading peaks to Nexus re #4137

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 63fa1482dc5be81122fbd4448319c04052acde77

comment:19 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:20 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Can create, save and load a peaks workspace. Realoaded workspace is the same as the original peaks workspace.

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 4984

Note: See TracTickets for help on using tickets.