Ticket #3800 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

HFIR SANS: add commands to set beam center for transmission

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Currently, the transmission runs assume that the beam center is at the same position as for the sample runs. That might not be the case. Add the following commands to set the beam center for transmission runs:

SetTransmissionBeamCenter() TransmissionDirectBeamCenter()

SetBckTransmissionBeamCenter() BckTransmissionDirectBeamCenter()

Change History

comment:1 Changed 9 years ago by Mathieu Doucet

In [14841]:

Added beam center for transmission. First cut. Re #3800

comment:2 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to accepted

Need tests.

comment:3 Changed 9 years ago by Mathieu Doucet

In [14852]:

fix bck trans beam ctr Re #3800

comment:4 Changed 9 years ago by Mathieu Doucet

In [14872]:

Fix problem with transmission beam center Re #3800

comment:5 Changed 9 years ago by Mathieu Doucet

Re #3800 Fix bug with transmission beam center

Changeset: 01b8677fce924b4128c205ffefd34ad19a34185e

comment:6 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

To test, try running the last unit tests in scripts/reduction/instruments/sans/utest_command_interface.py. For instance, if you run a reduction with and without calling SetTransmissionBeamCenter(), the results should be different.

comment:7 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

With some help from Mathieu got utest_command_interface running and tested with and without SetTransmissionBeamCenter and observed different results

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4647

Note: See TracTickets for help on using tickets.